Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ enforce check scores are between the min and max #3769

Merged
merged 3 commits into from
Jan 19, 2024
Merged

✨ enforce check scores are between the min and max #3769

merged 3 commits into from
Jan 19, 2024

Commits on Jan 4, 2024

  1. enforce check scores are between the min and max 

    if the score is invalid, the Error field is set and the score is
replaced with an inconclusive result score.

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    53c8c9c View commit details
    Browse the repository at this point in the history

  2. exclude inconclusive result score 

    Callers who want the score should use the CreateInconclusiveResult function.
The goal is partly to enforce a consistent coding style, and partly to
limit proportions which score to -1 accidentally.

Signed-off-by: Spencer Schrock <sschrock@google.com>
    @spencerschrock
    spencerschrock committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    4f95c9b View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Merge branch 'main' into bug/invalid-scores

    @spencerschrock
    spencerschrock committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    106efd5 View commit details
    Browse the repository at this point in the history