Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support .sigstore bundles to check for signed releases #3772

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Jan 5, 2024

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

Scorecard fails to detect *.sigstore signature bundles.

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #3771

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Support `.sigstore` bundles to check for signed releases

Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 5, 2024 04:25
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner January 5, 2024 04:25
@edgarrmondragon edgarrmondragon requested review from naveensrinivasan and spencerschrock and removed request for a team January 5, 2024 04:25
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Merging #3772 (b951f55) into main (55b6b76) will decrease coverage by 5.05%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3772      +/-   ##
==========================================
- Coverage   75.97%   70.92%   -5.05%     
==========================================
  Files         229      229              
  Lines       15381    15381              
==========================================
- Hits        11685    10909     -776     
- Misses       2975     3804     +829     
+ Partials      721      668      -53     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the .sigstore bundle extension
3 participants