Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉docs: Add .sigstore bundles to Signed-Releases #3922

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

cpswan
Copy link
Contributor

@cpswan cpswan commented Mar 5, 2024

What kind of change does this PR introduce?

docs

What is the current behavior?

.sigstore bundles were added to Signed-Releases check by #3772 but docs weren't updated

What is the new behavior (if this is a feature change)?**

Docs will reflect checks as they presently are in main

NA - [ ] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #3914

Special notes for your reviewer

checks.yaml was edited and then checks.md was generated with make generate-docs, but as it's a trivial change there's no obvious evidence of the docs generation process (which is probably as things should be).

Does this PR introduce a user-facing change?

Yes:

Document that `.sigstore` bundles are part of check for Signed-Releases

Signed-off-by: Chris Swan <478926+cpswan@users.noreply.github.com>
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #3922 (610e2e5) into main (d55dbd1) will decrease coverage by 4.58%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3922      +/-   ##
==========================================
- Coverage   75.08%   70.51%   -4.58%     
==========================================
  Files         234      234              
  Lines       15857    15857              
==========================================
- Hits        11907    11181     -726     
- Misses       3189     3965     +776     
+ Partials      761      711      -50     

@spencerschrock spencerschrock merged commit 16b6759 into ossf:main Mar 5, 2024
41 checks passed
fhoeborn pushed a commit to fhoeborn/scorecard that referenced this pull request Apr 1, 2024
Signed-off-by: Chris Swan <478926+cpswan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

BUG docs haven't been updated to say that Signed-Releases looks for .sigstore bundles.
2 participants