🐛 Refactor Dockerfile validation code to handle here-documents #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the `validateDockerfileInsecureDownloads` function to handle Dockerfiles that contain here-documents. This implementation handles the basic use-case, namely shell commands. It does not manage other interpreters that are specified through a she-bang, such as python. Fixes #3335 Signed-off-by: Jürgen Kreileder <jk@blackdown.de>
jkreileder
requested review from
naveensrinivasan and
justaugustus
and removed request for
a team
jkreileder
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3774 +/- ##
==========================================
- Coverage 75.47% 68.59% -6.89%
==========================================
Files 230 230
Lines 15613 15622 +9
==========================================
- Hits 11784 10716 -1068
- Misses 3103 4252 +1149
+ Partials 726 654 -72 |
jkreileder
commented
Jan 7, 2024
|
The other two missed branches (1 new, 1 old) are actually hard to trigger - at least I couldn't come up with something that triggers a parser error. In the old code, the here-docs triggered that case (and raised a sh level error). But that doesn't occur anymore with the fix. |
…loads() Signed-off-by: Jürgen Kreileder <jk@blackdown.de>
Signed-off-by: Jürgen Kreileder <jk@blackdown.de>
spencerschrock
approved these changes
Jan 10, 2024
jkreileder
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Jürgen Kreileder <jk@blackdown.de>
|
/scdiff generate Pinned-Dependencies |
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
The Pinned-Dependencies check fails on Dockerfiles that use here-documents.
RUN <<EOT1 <<EOT2 pip install --no-deps -e git+https://github.com/username/repo.git@v1.0#egg=package EOT1 curl bla | bash EOT2=>
What is the new behavior (if this is a feature change)?
Dockerfiles containing here-documents don't cause failures and the pin-status of the dependencies is correctly extracted.
Which issue(s) this PR fixes
Fixes #3335
Special notes for your reviewer
Does this PR introduce a user-facing change?