Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Refactor Dockerfile validation code to handle here-documents #3774

Merged
merged 5 commits into from
Jan 10, 2024
Merged

🐛 Refactor Dockerfile validation code to handle here-documents #3774

merged 5 commits into from
Jan 10, 2024

Commits on Jan 6, 2024

  1. Refactor Dockerfile validation code to handle here-documents 

    Refactors the `validateDockerfileInsecureDownloads` function to handle
Dockerfiles that contain here-documents.  This implementation handles the
basic use-case, namely shell commands.  It does not manage other
interpreters that are specified through a she-bang, such as python.

Fixes #3335

Signed-off-by: Jürgen Kreileder <jk@blackdown.de>
    @jkreileder
    jkreileder committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    ad1d159 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Add test for empty run command case in validateDockerfileInsecureDown… 

    …loads()

Signed-off-by: Jürgen Kreileder <jk@blackdown.de>
    @jkreileder
    jkreileder committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    e54b515 View commit details
    Browse the repository at this point in the history

  2. Simplify end line calculation in validateDockerfileInsecureDownloads() 

    Signed-off-by: Jürgen Kreileder <jk@blackdown.de>
    @jkreileder
    jkreileder committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    cce8ba1 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Document why we have a python test case here 

    Signed-off-by: Jürgen Kreileder <jk@blackdown.de>
    @jkreileder
    jkreileder committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    fc185b5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dockerfile-heredocs

    @spencerschrock
    spencerschrock committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f41e9a0 View commit details
    Browse the repository at this point in the history