Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Spelling #3804

Merged
merged 89 commits into from
Jan 26, 2024
Merged

📖 Spelling #3804

merged 89 commits into from
Jan 26, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 18, 2024

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

The misspellings have been reported at
https://github.com/jsoref/scorecard/actions/runs/7565320059/attempts/1#summary-20600890152

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

The action will report that the changes in this PR would make it happy:
https://github.com/jsoref/scorecard/actions/runs/7565320271/attempts/1#summary-20600890502

Which issue(s) this PR fixes

Special notes for your reviewer

I'm happy to drop any particular changes / changes to any particular files/paths or to split this as requested.

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

  • I'm concerned that the changes to jsonBranchProtectionSettings may be breaking. I think most of the other changes are harmless...

@jsoref
spelling: accurate
1f8f716 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: administrator
915fc45 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: analyze
76362ac 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: andtwenty
f8684b6 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: ascii
5af279d 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: association
ecc1faa 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: at least
3ed0d45 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: attestor
d8cf7e5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: barbaric
39df627 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: bucket
5a91fa4 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: by
0c64ce1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: can
4b55468 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: case-insensitive
b12e2e5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: case-sensitive
33a6b18 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: checking
1d729c5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: command-line
00d63cf 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: commit
07824aa 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: committed
c880347 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: conclusion
c7432eb 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: corresponding
cf9439a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: created
ce5115c 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: dataset
50713f1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: default
ab0b9b8 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: defines
155c4bc 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: dependabot
76557b7 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref requested a review from a team as a code owner January 18, 2024 04:31
@jsoref jsoref requested review from justaugustus and raghavkaul and removed request for a team January 18, 2024 04:31
jsoref
jsoref commented Jan 18, 2024
View reviewed changes
Makefile Show resolved Hide resolved
README.md Show resolved Hide resolved
checks/evaluation/pinned_dependencies.go Show resolved Hide resolved
checks/fileparser/github_workflow_test.go Show resolved Hide resolved
checks/raw/binary_artifact.go Outdated Show resolved Hide resolved
checks/testdata/.github/workflows/github-workflow-shells-specified-step.yaml Outdated Show resolved Hide resolved
checks/testdata/binaryartifacts/workflows/verify-outdated-action.yaml Show resolved Hide resolved
checks/testdata/securitypolicy/04_textAndDisclosureVulns Outdated Show resolved Hide resolved
cmd/package_managers_test.go Show resolved Hide resolved
pkg/json_raw_results.go Outdated Show resolved Hide resolved
@jsoref
spelling: successfully
8a75852 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: the
e32fd3e 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: their
d86a031 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: twenty
2df3f56 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: unexpected
6b930f6 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: unused
d82fc8a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: unverified
57db9d6 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: validate
e3b9ade 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: vendor
d078a58 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: vulnerabilities
ac728cb 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: vulns
0972875 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: will
02f0c2f 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: without
a71199c 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: workflow
ba05c9a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: workflows
90abed0 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Copy link
Contributor Author

jsoref commented Jan 20, 2024

Thanks @spencerschrock (this comment is mostly present so that it's easier to see the diff for the force push here in case there's another force push later).

@jsoref
Copy link
Contributor Author

jsoref commented Jan 26, 2024

So, should this be 👻 ? 🐛 ? I think we're ruled out the things we think are ⚠️ worthy...
I don't think it's ✨ and while some of the changes are 📖, many aren't.

Is it 🌱 because it's "other"?

@spencerschrock
Copy link
Member

So, should this be 👻 ? 🐛 ? I think we're ruled out the things we think are ⚠️ worthy... I don't think it's ✨ and while some of the changes are 📖, many aren't.

Is it 🌱 because it's "other"?

I was debating between :seedling: and :book:, so happy to accept either.
I usually merge typo fixes as :book: since they don't change any of the behavior, even if it's strictly not documentation.

@jsoref jsoref changed the title ⚠️ Spelling :boo: Spelling Jan 26, 2024
@jsoref jsoref changed the title :boo: Spelling 📖 Spelling Jan 26, 2024
@jsoref
Copy link
Contributor Author

jsoref commented Jan 26, 2024

Sold. Note that it might be worthwhile to update the documentation to that effect (to some extent, projects should try to reduce "cognitive load" on external contributors).

Thanks for the fast iteration, I appreciate it.

@spencerschrock spencerschrock enabled auto-merge (squash) January 26, 2024 23:00
@spencerschrock spencerschrock merged commit 3b94825 into ossf:main Jan 26, 2024
37 of 38 checks passed
@jsoref jsoref deleted the spelling branch January 27, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerschrock spencerschrock spencerschrock approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus justaugustus is a code owner automatically assigned from ossf/scorecard-maintainers

@raghavkaul raghavkaul Awaiting requested review from raghavkaul raghavkaul is a code owner automatically assigned from ossf/scorecard-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsoref @pnacht @spencerschrock @raghavkaul