Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Spelling #3804

Merged
merged 89 commits into from
Jan 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
1f8f716
spelling: accurate
jsoref Jan 18, 2024
915fc45
spelling: administrator
jsoref Jan 18, 2024
76362ac
spelling: analyze
jsoref Jan 18, 2024
f8684b6
spelling: andtwenty
jsoref Jan 18, 2024
5af279d
spelling: ascii
jsoref Jan 18, 2024
ecc1faa
spelling: association
jsoref Jan 18, 2024
3ed0d45
spelling: at least
jsoref Jan 18, 2024
d8cf7e5
spelling: attestor
jsoref Jan 18, 2024
39df627
spelling: barbaric
jsoref Jan 18, 2024
5a91fa4
spelling: bucket
jsoref Jan 18, 2024
0c64ce1
spelling: by
jsoref Jan 18, 2024
4b55468
spelling: can
jsoref Jan 18, 2024
b12e2e5
spelling: case-insensitive
jsoref Jan 18, 2024
33a6b18
spelling: case-sensitive
jsoref Jan 18, 2024
1d729c5
spelling: checking
jsoref Jan 18, 2024
00d63cf
spelling: command-line
jsoref Jan 18, 2024
07824aa
spelling: commit
jsoref Jan 18, 2024
c880347
spelling: committed
jsoref Jan 18, 2024
c7432eb
spelling: conclusion
jsoref Jan 18, 2024
cf9439a
spelling: corresponding
jsoref Jan 18, 2024
ce5115c
spelling: created
jsoref Jan 18, 2024
50713f1
spelling: dataset
jsoref Jan 18, 2024
ab0b9b8
spelling: default
jsoref Jan 18, 2024
155c4bc
spelling: defines
jsoref Jan 18, 2024
76557b7
spelling: dependabot
jsoref Jan 18, 2024
cdea5cc
spelling: dependency
jsoref Jan 18, 2024
c980ab3
spelling: depending
jsoref Jan 18, 2024
d3a8c11
spelling: desired
jsoref Jan 18, 2024
5ca2450
spelling: different
jsoref Jan 18, 2024
1f07214
spelling: disclose
jsoref Jan 18, 2024
98775d0
spelling: download
jsoref Jan 18, 2024
215584e
spelling: each
jsoref Jan 18, 2024
abf5203
spelling: enforce
jsoref Jan 18, 2024
e327815
spelling: every time
jsoref Jan 18, 2024
dd7d93e
spelling: exist
jsoref Jan 18, 2024
ce2b117
spelling: existing
jsoref Jan 18, 2024
0e403c0
spelling: fields
jsoref Jan 18, 2024
171f869
spelling: files
jsoref Jan 18, 2024
e0de5fa
spelling: for
jsoref Jan 18, 2024
ca9f102
spelling: force-push
jsoref Jan 18, 2024
5e02eb7
spelling: github
jsoref Jan 18, 2024
f25fb78
spelling: gitlab
jsoref Jan 18, 2024
54ca0ed
spelling: ignoreed
jsoref Jan 18, 2024
427ab81
spelling: implementation
jsoref Jan 18, 2024
26ecde7
spelling: implements
jsoref Jan 18, 2024
dfda20c
spelling: increase
jsoref Jan 18, 2024
d2b6b7d
spelling: indicates
jsoref Jan 18, 2024
6e9a890
spelling: initialized
jsoref Jan 18, 2024
9615774
spelling: instructions
jsoref Jan 18, 2024
ee188d1
spelling: invalid
jsoref Jan 18, 2024
62ee5c0
spelling: marshal
jsoref Jan 18, 2024
e6decad
spelling: match
jsoref Jan 18, 2024
2ddb490
spelling: name
jsoref Jan 18, 2024
9a16d86
spelling: nonexistent
jsoref Jan 18, 2024
9bee8f7
spelling: organization
jsoref Jan 18, 2024
f9dc606
spelling: package
jsoref Jan 18, 2024
92a6680
spelling: provenance
jsoref Jan 18, 2024
837653b
spelling: query
jsoref Jan 18, 2024
9cfaf2f
spelling: readers
jsoref Jan 18, 2024
c0c495b
spelling: receive
jsoref Jan 18, 2024
170347a
spelling: registered
jsoref Jan 18, 2024
31b4e1c
spelling: remediate
jsoref Jan 18, 2024
0568d56
spelling: representation
jsoref Jan 18, 2024
05fd525
spelling: requests
jsoref Jan 18, 2024
89a5217
spelling: requires
jsoref Jan 18, 2024
e697169
spelling: return
jsoref Jan 18, 2024
eea2ba1
spelling: scorecard
jsoref Jan 18, 2024
8074d39
spelling: separator
jsoref Jan 18, 2024
c035b87
spelling: serialization
jsoref Jan 18, 2024
dddd6ae
spelling: sign up
jsoref Jan 18, 2024
46e6371
spelling: specifications
jsoref Jan 18, 2024
3579964
spelling: specified
jsoref Jan 18, 2024
e04c3ba
spelling: success
jsoref Jan 18, 2024
8a75852
spelling: successfully
jsoref Jan 18, 2024
e32fd3e
spelling: the
jsoref Jan 18, 2024
d86a031
spelling: their
jsoref Jan 20, 2024
2df3f56
spelling: twenty
jsoref Jan 18, 2024
6b930f6
spelling: unexpected
jsoref Jan 18, 2024
d82fc8a
spelling: unused
jsoref Jan 18, 2024
57db9d6
spelling: unverified
jsoref Jan 18, 2024
e3b9ade
spelling: validate
jsoref Jan 18, 2024
d078a58
spelling: vendor
jsoref Jan 18, 2024
ac728cb
spelling: vulnerabilities
jsoref Jan 18, 2024
0972875
spelling: vulns
jsoref Jan 18, 2024
02f0c2f
spelling: will
jsoref Jan 18, 2024
a71199c
spelling: without
jsoref Jan 18, 2024
ba05c9a
spelling: workflow
jsoref Jan 18, 2024
90abed0
spelling: workflows
jsoref Jan 18, 2024
296ff6a
Merge branch 'main' into spelling
spencerschrock Jan 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
permissions:
contents: read
needs: docs_only_check
# ideally we put one "if" here, but due to how skipped matrix jobs work, we need one for each each step
# ideally we put one "if" here, but due to how skipped matrix jobs work, we need one for each step
# https://github.com/orgs/community/discussions/9141
steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scdiff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
if: ${{ (github.event.issue.pull_request) && (contains(github.event.comment.body, '/scdiff generate')) }}
runs-on: [ubuntu-latest]
steps:
- name: create file of repos to anlayze
- name: create file of repos to analyze
run: |
cat <<EOF > $HOME/repos.txt
https://github.com/airbnb/lottie-web
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ validate-projects: ./cron/internal/data/projects.csv | build-validate-script
./cron/internal/data/validate/validate ./cron/internal/data/gitlab-projects-releasetest.csv

tree-status: | all-targets-update-dependencies ## Verify tree is clean and all changes are committed
# Verify the tree is clean and all changes are commited
# Verify the tree is clean and all changes are committed
./scripts/tree-status

###############################################################################
Expand Down Expand Up @@ -255,7 +255,7 @@ build-attestor-docker: ## Build scorecard-attestor Docker image
build-attestor-docker:
DOCKER_BUILDKIT=1 docker build . --file attestor/Dockerfile \
--tag scorecard-attestor:latest \
--tag scorecard-atttestor:$(GIT_HASH)
--tag scorecard-attestor:$(GIT_HASH)
raghavkaul marked this conversation as resolved.
Show resolved Hide resolved

TOKEN_SERVER_DEPS = $(shell find clients/githubrepo/roundtripper/tokens/ -iname "*.go")
build-github-server: ## Build GitHub token server
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ RESULTS
| | | | review dismissal enabled on | |
| | | | branch 'main' Info: Owner | |
| | | | review required on branch | |
| | | | 'main' Info: 'admininistrator' | |
| | | | 'main' Info: 'administrator' | |
| | | | PRs need reviews before being | |
| | | | merged on branch 'main' | |
|---------|------------------------|--------------------------------|--------------------------------|---------------------------------------------------------------------------|
Expand Down Expand Up @@ -559,7 +559,7 @@ risk level.
### Report Problems

If you have what looks like a bug, please use the
[Github issue tracking system.](https://github.com/ossf/scorecard/issues) Before
[GitHub issue tracking system.](https://github.com/ossf/scorecard/issues) Before
spencerschrock marked this conversation as resolved.
Show resolved Hide resolved
you file an issue, please search existing issues to see if your issue is already
covered.

Expand Down
2 changes: 1 addition & 1 deletion attestor/policy/attestation_policy.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func (ap *AttestationPolicy) EvaluateResults(raw *checker.RawResults) (PolicyRes

if ap.EnsureCodeReviewed {
// By default, if code review reqs. aren't specified, we assume
// the user wants there to be atleast one reviewer
// the user wants there to be at least one reviewer
if len(ap.CodeReviewRequirements.RequiredApprovers) == 0 &&
ap.CodeReviewRequirements.MinReviewers == 0 {
ap.CodeReviewRequirements.MinReviewers = 1
Expand Down
4 changes: 2 additions & 2 deletions checker/raw_result.go
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ type Run struct {
URL string
}

// ArchivedStatus definess the archived status.
// ArchivedStatus defines the archived status.
type ArchivedStatus struct {
Status bool
// TODO: add fields, e.g., date of archival.
Expand All @@ -348,7 +348,7 @@ type File struct {
// TODO: add hash.
}

// CIIBestPracticesData contains data foor CIIBestPractices check.
// CIIBestPracticesData contains data for CIIBestPractices check.
type CIIBestPracticesData struct {
Badge clients.BadgeLevel
}
Expand Down
2 changes: 1 addition & 1 deletion checks/dependency_update_tool.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
"github.com/ossf/scorecard/v4/probes/zrunner"
)

// CheckDependencyUpdateTool is the exported name for Automatic-Depdendency-Update.
// CheckDependencyUpdateTool is the exported name for Dependency-Update-Tool.
const CheckDependencyUpdateTool = "Dependency-Update-Tool"

//nolint:gochecknoinits
Expand Down
4 changes: 2 additions & 2 deletions checks/evaluation/branch_protection.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func BranchProtection(name string, dl checker.DetailLogger,
var score levelScore
b := r.Branches[i]

// Protected field only indates that the branch matches
// Protected field only indicates that the branch matches
// one `Branch protection rules`. All settings may be disabled,
// so it does not provide any guarantees.
protected := !(b.Protected != nil && !*b.Protected)
Expand Down Expand Up @@ -361,7 +361,7 @@ func adminThoroughReviewProtection(branch *clients.BranchRef, dl checker.DetailL

// nil typically means we do not have access to the value.
if branch.BranchProtectionRule.EnforceAdmins != nil {
// Note: we don't inrecase max possible score for non-admin viewers.
// Note: we don't increase max possible score for non-admin viewers.
max++
switch *branch.BranchProtectionRule.EnforceAdmins {
case true:
Expand Down
2 changes: 1 addition & 1 deletion checks/evaluation/dangerous_workflow_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func TestDangerousWorkflow(t *testing.T) {
},
},
{
name: "DangerousWorkflow - no worklflows",
name: "DangerousWorkflow - no workflows",
findings: []finding.Finding{
{
Probe: "hasDangerousWorkflowScriptInjection",
Expand Down
14 changes: 7 additions & 7 deletions checks/evaluation/pinned_dependencies.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ type pinnedResult struct {

// Structure to host information about pinned github
// or third party dependencies.
type worklowPinningResult struct {
type workflowPinningResult struct {
jsoref marked this conversation as resolved.
Show resolved Hide resolved
thirdParties pinnedResult
gitHubOwned pinnedResult
}
Expand Down Expand Up @@ -209,7 +209,7 @@ func PinningDependencies(name string, c *checker.CheckRequest,
return checker.CreateRuntimeErrorResult(name, e)
}

var wp worklowPinningResult
var wp workflowPinningResult
pr := make(map[checker.DependencyUseType]pinnedResult)
dl := c.Dlogger

Expand Down Expand Up @@ -269,7 +269,7 @@ func PinningDependencies(name string, c *checker.CheckRequest,
// Go through all dependency types
// GitHub Actions need to be handled separately since they are not in pr
scores = append(scores, createScoreForGitHubActionsWorkflow(&wp, dl)...)
// Only exisiting dependencies will be found in pr
// Only existing dependencies will be found in pr
// We will only score the ecosystem if there are dependencies
// This results in only existing ecosystems being included in the final score
for t := range pr {
Expand Down Expand Up @@ -300,10 +300,10 @@ func PinningDependencies(name string, c *checker.CheckRequest,

func updatePinningResults(dependencyType checker.DependencyUseType,
outcome finding.Outcome, snippet *string,
wp *worklowPinningResult, pr map[checker.DependencyUseType]pinnedResult,
wp *workflowPinningResult, pr map[checker.DependencyUseType]pinnedResult,
) {
if dependencyType == checker.DependencyUseTypeGHAction {
// Note: `Snippet` contains `action/name@xxx`, so we cna use it to infer
// Note: `Snippet` contains `action/name@xxx`, so we can use it to infer
// if it's a GitHub-owned action or not.
gitHubOwned := fileparser.IsGitHubOwnedAction(*snippet)
addWorkflowPinnedResult(outcome, wp, gitHubOwned)
Expand Down Expand Up @@ -345,7 +345,7 @@ func addPinnedResult(outcome finding.Outcome, r *pinnedResult) {
r.total += 1
}

func addWorkflowPinnedResult(outcome finding.Outcome, w *worklowPinningResult, isGitHub bool) {
func addWorkflowPinnedResult(outcome finding.Outcome, w *workflowPinningResult, isGitHub bool) {
if isGitHub {
addPinnedResult(outcome, &w.gitHubOwned)
} else {
Expand All @@ -359,7 +359,7 @@ func logPinnedResult(dl checker.DetailLogger, p pinnedResult, name string) {
})
}

func createScoreForGitHubActionsWorkflow(wp *worklowPinningResult, dl checker.DetailLogger,
func createScoreForGitHubActionsWorkflow(wp *workflowPinningResult, dl checker.DetailLogger,
) []checker.ProportionalScoreWeighted {
if wp.gitHubOwned.total == 0 && wp.thirdParties.total == 0 {
return []checker.ProportionalScoreWeighted{}
Expand Down
Loading
Loading