-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added probe for permissive licenses #3838
Conversation
3562d2f
to
db3bc43
Compare
Can you open an issue for discussion? Our contributing.md outlines the steps:
(there's also some parts about how to implement that are probably out of date now. but I see you have the implementation using probes which is good) |
Thanks for the hint, I opened a issue here #3840 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
a few nits
This pull request has been marked stale because it has been open for 10 days with no activity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the probe portion, which generally looks good.
This pull request has been marked stale because it has been open for 10 days with no activity |
Signed-off-by: Felix Hoeborn <f.hoeborn@gmail.com>
Signed-off-by: Felix Hoeborn <f.hoeborn@gmail.com>
Signed-off-by: Felix Hoeborn <f.hoeborn@gmail.com>
Signed-off-by: Felix Hoeborn <f.hoeborn@gmail.com>
Signed-off-by: Felix Hoeborn <f.hoeborn@gmail.com>
Signed-off-by: Felix Hoeborn <f.hoeborn@gmail.com>
Signed-off-by: Felix Hoeborn <98820380+fhoeborn@users.noreply.github.com>
…ed tests Signed-off-by: Felix Hoeborn <f.hoeborn@gmail.com>
I adjusted the code a bit based upon your review comments, did you have a chance to look into the rest of the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the code a bit based upon your review comments, did you have a chance to look into the rest of the PR?
The reason I focused on the probe code was based on my comment here: #3840 (comment)
I am happy to merge the probe code which is why my review focused on it, but having permissive license as a check is too opinionated (in my opinion) to have as a check for all callers. Full response in the attached issue #3840 (comment)
…ntly Signed-off-by: Felix Hoeborn <f.hoeborn@gmail.com>
Thanks for the suggestion! |
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution and being patient / flexible.
Note: for time reasons I went ahead and added a small bit of metadata (related to #4020) and fixed the linter to get this merged before our v5 prerelease candidate (hopefully tomorrow!).
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Fixes #3840
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)