Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: Remove global sync by default #2968

Merged
merged 1 commit into from
Aug 30, 2023

Commits on Aug 14, 2023

  1. deploy: Remove global sync by default

    Our previous change here was not actually sufficient for
    the ceph case, because what (I think) is happening is that
    our other `syncfs()` invocation is getting blocked on some
    kernel mutexes that are used in `sync`, and that's causing the
    process to fully block.
    
    We should not be dependent on a full filesystem `sync`, only
    on the sync of the sysroot and boot filesystems.
    
    Anyone who *does* want this behavior could inject an override
    for `ostree-finalize-staged.service` that overrides `ExecStop`
    to add a run of `sync`.
    cgwalters committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    fa69eaa View commit details
    Browse the repository at this point in the history