deploy: Remove global sync by default
#2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK I think we should do this PR at some point, but some more investigation here narrowed in on #2969 |
Our previous change here was not actually sufficient for the ceph case, because what (I think) is happening is that our other `syncfs()` invocation is getting blocked on some kernel mutexes that are used in `sync`, and that's causing the process to fully block. We should not be dependent on a full filesystem `sync`, only on the sync of the sysroot and boot filesystems. Anyone who *does* want this behavior could inject an override for `ostree-finalize-staged.service` that overrides `ExecStop` to add a run of `sync`.
cgwalters
force-pushed
the
drop-global-syncfs-by-default
branch
from
aea3c2e
to
fa69eaa
Compare
|
Lifting draft on this one, I think we should merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our previous change here was not actually sufficient for the ceph case, because what (I think) is happening is that our other
syncfs()invocation is getting blocked on some kernel mutexes that are used insync, and that's causing the process to fully block.We should not be dependent on a full filesystem
sync, only on the sync of the sysroot and boot filesystems.Anyone who does want this behavior could inject an override for
ostree-finalize-staged.servicethat overridesExecStopto add a run ofsync.