deploy: Fix mutex locking for global sync timeout #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The locking here was always too long - by holding the mutex during the `sync()` call, it means `g_cond_wait_until()` can never wake up (because its API requires the mutex to be locked). Confusingly though of course we do still print the "timed out" message, and I think that tricked us when we were doing testing here. We only need to lock the mutex when we're manipulating shared state, which basically boils down to the `gboolean success`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locking here was always too long - by holding the mutex during the
sync()call, it meansg_cond_wait_until()can never wake up (because its API requires the mutex to be locked).Confusingly though of course we do still print the "timed out" message, and I think that tricked us when we were doing testing here.
We only need to lock the mutex when we're manipulating shared state, which basically boils down to the
gboolean success.