2023.6 coverity minor fixes #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the continuation of unit testing coverage.
Coverity points out that since we're now *always* initializing metadata, the `create_empty_gvariant_dict()` is unreachable.
Spotted by coverity.
Coverity complains about this, even though they're the same thing.
ericcurtin
reviewed
Aug 26, 2023
| @@ -415,17 +415,18 @@ ostree_sign_ed25519_add_pk (OstreeSign *self, GVariant *public_key, GError **err | |||
| if (!_ostree_sign_ed25519_is_initialized (sign, error)) | |||
| return FALSE; | |||
|
|
|||
| gpointer key = NULL; | |||
| g_autofree guint8 *key_owned = NULL; | |||
| const guint8 *key = NULL; | |||
There was a problem hiding this comment.
Why not?
g_autofree const guint8 *key = NULL;
key_owned is unused, just set.
There was a problem hiding this comment.
Because g_variant_get_fixed_array() returns a const pointer into its data, whereas g_base64_decode returns a new value. Notice that we do set key_owned only in the latter case.
There was a problem hiding this comment.
Ah I see, so you want it free'd at the end of scope in one case but not the other... Makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switchroot: Lower config parser to otcore, add unit tests
Part of the continuation of unit testing coverage.
commit: Drop dead code
Coverity points out that since we're now always initializing
metadata, the
create_empty_gvariant_dict()is unreachable.sign/ed25519: Fix two memory leaks
Spotted by coverity.
switchroot: Use g_new/g_free consistently
Coverity complains about this, even though they're the same thing.