Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2023.6 coverity minor fixes #3013

Merged
merged 4 commits into from
Aug 26, 2023
Merged

2023.6 coverity minor fixes #3013

merged 4 commits into from
Aug 26, 2023

Commits on Aug 25, 2023

  1. switchroot: Lower config parser to otcore, add unit tests 

    Part of the continuation of unit testing coverage.
    @cgwalters
    cgwalters committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d36bf35 View commit details
    Browse the repository at this point in the history

  2. commit: Drop dead code 

    Coverity points out that since we're now *always* initializing
metadata, the `create_empty_gvariant_dict()` is unreachable.
    @cgwalters
    cgwalters committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    a87789e View commit details
    Browse the repository at this point in the history

  3. sign/ed25519: Fix two memory leaks 

    Spotted by coverity.
    @cgwalters
    cgwalters committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d3ede20 View commit details
    Browse the repository at this point in the history

  4. switchroot: Use g_new/g_free consistently 

    Coverity complains about this, even though they're the same thing.
    @cgwalters
    cgwalters committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    1a16a7d View commit details
    Browse the repository at this point in the history