More analyzer fixes 2 #3016
Merged
More analyzer fixes 2 #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to free this value on each iteration; it's moved below if the value is used.
It's warning the value can be NULL, but I don't think that's true. I believe we're just hitting analysis limit (the path length is 119).
This is just another instance of the "conditionally owned" pattern.
Just used for side-effects.
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/repo-finder: Squash memory leak
We want to free this value on each iteration; it's moved below
if the value is used.
pull: Add assertions to quiet clang-analyzer
It's warning the value can be NULL, but I don't think that's true.
I believe we're just hitting analysis limit (the path length is 119).
commit: Quiet clang-analyzer warning
This is just another instance of the "conditionally owned"
pattern.
pull: Quiet clang-analyzer warning
Just used for side-effects.