Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More analyzer fixes 2 #3016

Merged
merged 4 commits into from
Aug 28, 2023
Merged

More analyzer fixes 2 #3016

merged 4 commits into from
Aug 28, 2023

Commits on Aug 26, 2023

  1. lib/repo-finder: Squash memory leak 

    We want to free this value on each iteration; it's moved below
if the value is used.
    @cgwalters
    cgwalters committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    0cfa5e8 View commit details
    Browse the repository at this point in the history

  2. pull: Add assertions to quiet clang-analyzer 

    It's warning the value can be NULL, but I don't think that's true.
I believe we're just hitting analysis limit (the path length is 119).
    @cgwalters
    cgwalters committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    5b40d4b View commit details
    Browse the repository at this point in the history

  3. commit: Quiet clang-analyzer warning 

    This is just another instance of the "conditionally owned"
pattern.
    @cgwalters
    cgwalters committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    e2779a7 View commit details
    Browse the repository at this point in the history

  4. pull: Quiet clang-analyzer warning 

    Just used for side-effects.
    @cgwalters
    cgwalters committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    0beaf5c View commit details
    Browse the repository at this point in the history