admin/state-overlay: Require root and don't lock sysroot #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not required for anything in particular, but it's good to use the right flags here anyway.
ericcurtin
approved these changes
Feb 6, 2024
cgwalters
approved these changes
Feb 6, 2024
|
Ahh wait, I think I see the problem with the ISO: |
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Feb 6, 2024
This doesn't work anymore since systemd locked down where generators
can write files:
[ 9.246494] /usr/lib/systemd/system-generators/coreos-liveiso-autologin-generator: line 24: /etc/sysctl.d/20-coreos-autologin-kernel-printk.conf: Read-only file system
But anyway, nowadays this duplicates `coreos-printk-quiet.service` which
was added two years after this code was written (coreos#1840).
Noticed by Colin in
ostreedev/ostree#3158 (comment).
In CoreOS live environments, we do have `/run/ostree` but no `ostree=` karg; we hackily fool `ostree-prepare-root.service` by bind-mounting over `/proc/cmdline` so it does the right thing. Presumably, we should clean this up eventually, but even so we don't want to require PXE users to add an `ostree=` arg, so we need to tolerate this. So this assertion would fail there. Restore the behaviour prior to b9ce0e8 and re-add a more contemporary comment. Fixes b9ce0e8 ("generator: Exit if there's no `/run/ostree`").
Nice. First one fixed by coreos/fedora-coreos-config#2839. For the second one, added a commit which I didn't test, but I'm 99% sure will fix it. Now... why this passed CI in #3147 but failed here, I'm not sure. |
cgwalters
approved these changes
Feb 6, 2024
dustymabe
pushed a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Feb 6, 2024
This doesn't work anymore since systemd locked down where generators
can write files:
[ 9.246494] /usr/lib/systemd/system-generators/coreos-liveiso-autologin-generator: line 24: /etc/sysctl.d/20-coreos-autologin-kernel-printk.conf: Read-only file system
But anyway, nowadays this duplicates `coreos-printk-quiet.service` which
was added two years after this code was written (#1840).
Noticed by Colin in
ostreedev/ostree#3158 (comment).
aaradhak
pushed a commit
to aaradhak/fedora-coreos-config
that referenced
this pull request
Mar 18, 2024
This doesn't work anymore since systemd locked down where generators
can write files:
[ 9.246494] /usr/lib/systemd/system-generators/coreos-liveiso-autologin-generator: line 24: /etc/sysctl.d/20-coreos-autologin-kernel-printk.conf: Read-only file system
But anyway, nowadays this duplicates `coreos-printk-quiet.service` which
was added two years after this code was written (coreos#1840).
Noticed by Colin in
ostreedev/ostree#3158 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not required for anything in particular, but it's good to use the right flags here anyway.