Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin/state-overlay: Require root and don't lock sysroot #3158

Merged
merged 2 commits into from
Feb 6, 2024
Merged

admin/state-overlay: Require root and don't lock sysroot #3158

merged 2 commits into from
Feb 6, 2024

Commits on Feb 6, 2024

  1. admin/state-overlay: Require root and don't lock sysroot 

    Not required for anything in particular, but it's good to use the right
flags here anyway.
    @jlebon
    jlebon committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    31b804f View commit details
    Browse the repository at this point in the history

  2. generator: Restore graceful exit behaviour if ostree karg missing 

    In CoreOS live environments, we do have `/run/ostree` but no `ostree=`
karg; we hackily fool `ostree-prepare-root.service` by bind-mounting
over `/proc/cmdline` so it does the right thing. Presumably, we should
clean this up eventually, but even so we don't want to require PXE users
to add an `ostree=` arg, so we need to tolerate this.

So this assertion would fail there. Restore the behaviour prior to
b9ce0e8 and re-add a more contemporary comment.

Fixes b9ce0e8 ("generator: Exit if there's no `/run/ostree`").
    @jlebon
    jlebon committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    15ec339 View commit details
    Browse the repository at this point in the history