Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newspells and edited formulas. #12

Merged
merged 11 commits into from
Jul 24, 2013
Merged

Newspells and edited formulas. #12

merged 11 commits into from
Jul 24, 2013

Conversation

nclx
Copy link
Contributor

@nclx nclx commented Jul 24, 2013

All new spells are working, I tested most of those but tested only in a certain level / mlvl etc so formulas maybe are bad and dont escalate properly.

Some old spell formulas are modified and also tested in certain level.

Used tibiastats as reference for damages, some guys opinions and tibiawiki for few details.

Many spells are taken from 0.3 but had to modify the formula etc, others are from some otland "100% rl" spellpack, others I made myself.

I have now uploaded new spells (and old spells modified) to the server so players will test now, if some formula or spell is fucked I'll fix and make new pull request.

@marksamman
Copy link
Member

setCombatParam always takes a number for the third parameter, and in the case of "booleans", we need to pass 0 or 1. FALSE is equivalent to false which is not 0 in Lua (true is 0 in Lua). Replace all FALSE/TRUE with 0/1 for setCombatParams and I will merge this.

…aram[(](.*), (.*), (false|FALSE)[)]/setCombatParam(\1, \2, 0)/' {} \; I hope it worked XD
@nclx
Copy link
Contributor Author

nclx commented Jul 24, 2013

Ah yes worked yay

marksamman added a commit that referenced this pull request Jul 24, 2013
New spells and updated formulas
@marksamman marksamman merged commit 9165eec into otland:master Jul 24, 2013
@nclx nclx mentioned this pull request Aug 7, 2013
@Jonas21 Jonas21 mentioned this pull request Dec 28, 2013
@alanlebek alanlebek mentioned this pull request Mar 2, 2014
@marksamman marksamman modified the milestone: 1.0 Mar 19, 2014
@AndreFaramir AndreFaramir mentioned this pull request Dec 4, 2014
This was referenced Dec 29, 2015
@Donkey-Robot Donkey-Robot mentioned this pull request Jan 5, 2016
@fironfox fironfox mentioned this pull request Apr 16, 2016
@dadasko dadasko mentioned this pull request Apr 24, 2016
@walissonsantos walissonsantos mentioned this pull request May 19, 2016
@Healek Healek mentioned this pull request Aug 18, 2016
@Donkey-Robot Donkey-Robot mentioned this pull request Nov 19, 2016
@Donkey-Robot Donkey-Robot mentioned this pull request Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Increase or improvement in quality, value, or extent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants