Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mutation to delete healthcare professional #846

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

NabbeunNabi
Copy link
Contributor

@NabbeunNabi NabbeunNabi commented Oct 23, 2024

Resolves #845

🔧 What changed

A mutation was added to delete a healthcare professional. This is important as we will in the future need to delete healthcare professionals that retire or go on sabbatical and are not actively practicing.

🧪 Testing instructions

Tests will be added after the implementation of ticket #832

@NabbeunNabi NabbeunNabi self-assigned this Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for findadoc ready!

Name Link
🔨 Latest commit b7dba0e
🔍 Latest deploy log https://app.netlify.com/sites/findadoc/deploys/672a0adb5f375400084b3195
😎 Deploy Preview https://deploy-preview-846--findadoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NabbeunNabi NabbeunNabi added the enhancement New feature or request label Oct 23, 2024
@NabbeunNabi NabbeunNabi marked this pull request as ready for review October 23, 2024 00:49
@NabbeunNabi NabbeunNabi marked this pull request as draft October 23, 2024 03:11
@NabbeunNabi NabbeunNabi marked this pull request as ready for review October 23, 2024 03:19
Copy link
Contributor

@ermish ermish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naisu

stores/healthcareProfessionalsStore.ts Show resolved Hide resolved
@NabbeunNabi NabbeunNabi force-pushed the feat/delete-mutation-healthcare-professionals branch from 5e08796 to 9d9e74b Compare October 25, 2024 03:06
@NabbeunNabi NabbeunNabi requested a review from ermish October 25, 2024 03:12
@NabbeunNabi NabbeunNabi force-pushed the feat/delete-mutation-healthcare-professionals branch from 4721f72 to c8e904f Compare October 29, 2024 07:52
@NabbeunNabi NabbeunNabi marked this pull request as draft October 29, 2024 23:55
@NabbeunNabi NabbeunNabi force-pushed the feat/delete-mutation-healthcare-professionals branch from c8e904f to 05971e6 Compare October 30, 2024 01:02
@NabbeunNabi NabbeunNabi marked this pull request as ready for review October 30, 2024 01:04
Copy link
Contributor

@ermish ermish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@ermish ermish merged commit fcd0117 into main Nov 5, 2024
11 checks passed
@ermish ermish deleted the feat/delete-mutation-healthcare-professionals branch November 5, 2024 12:12
ProgressChris88 pushed a commit that referenced this pull request Nov 14, 2024
…nForm.

add healthcareprofessionalsection to locales.
create healthcareprofessionalsection cypress test.
add sectionfields to healthcareProfessionalsStore.

Co-authored-by: Chris Bowman <ProgressChris88@users.noreply.github.com>
Co-authored-by: Karl Komeya <karlk08@users.noreply.github.com>
Co-authored-by: NabbeunNabi <williamedwardbrammer@gmail.com>

Co-authored-by: NabbeunNabi <williamedwardbrammer@gmail.com>
Co-authored-by: Matt Keighley <matt@squareonejapan.com>

test: set defaultCommandTimeout to 10000ms for stability (#867)

* test: increase defaultCommandTimeout to 10000ms for stability

Co-authored-by: gminetoma <gminetoma@gmail.com>

* chore: remove unnecessary timeouts in test files

---------

Co-authored-by: gminetoma <gminetoma@gmail.com>

feat: implement mod top bar UI for hp and facility (#865)

chore: update contributors manually (#862)

feat: add mutation to delete existing facility (#847)

Co-authored-by: Philip Ermish <philipermish@gmail.com>

feat: add result type to frontend (#875)

Co-authored-by: Philip Ermish <philipermish@gmail.com>

feat: add mutation to delete healthcare professional (#846)

Add localeFormatting from localeStore to format languages for name locale, spoken languages, and healthcareProfessional's locale. (#879)

Fix healthcareProfessionalName.locale from array to string.

Co-authored-by: Philip Ermish <philipermish@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add delete mutation for healthcare professional to the healthcareProfessionalStore.ts
2 participants