-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add server response type to frontend #875
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for findadoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NabbeunNabi
changed the title
feat: add result type to frontend
feat: add server response type to frontend
Oct 30, 2024
NabbeunNabi
force-pushed
the
feat/add-result-type-frontend
branch
from
October 30, 2024 23:32
5332d4c
to
7321301
Compare
ermish
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no errors
ProgressChris88
pushed a commit
that referenced
this pull request
Nov 14, 2024
…nForm. add healthcareprofessionalsection to locales. create healthcareprofessionalsection cypress test. add sectionfields to healthcareProfessionalsStore. Co-authored-by: Chris Bowman <ProgressChris88@users.noreply.github.com> Co-authored-by: Karl Komeya <karlk08@users.noreply.github.com> Co-authored-by: NabbeunNabi <williamedwardbrammer@gmail.com> Co-authored-by: NabbeunNabi <williamedwardbrammer@gmail.com> Co-authored-by: Matt Keighley <matt@squareonejapan.com> test: set defaultCommandTimeout to 10000ms for stability (#867) * test: increase defaultCommandTimeout to 10000ms for stability Co-authored-by: gminetoma <gminetoma@gmail.com> * chore: remove unnecessary timeouts in test files --------- Co-authored-by: gminetoma <gminetoma@gmail.com> feat: implement mod top bar UI for hp and facility (#865) chore: update contributors manually (#862) feat: add mutation to delete existing facility (#847) Co-authored-by: Philip Ermish <philipermish@gmail.com> feat: add result type to frontend (#875) Co-authored-by: Philip Ermish <philipermish@gmail.com> feat: add mutation to delete healthcare professional (#846) Add localeFormatting from localeStore to format languages for name locale, spoken languages, and healthcareProfessional's locale. (#879) Fix healthcareProfessionalName.locale from array to string. Co-authored-by: Philip Ermish <philipermish@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #877
🔧 What changed
Before we didn't have types that matched our responses from the backend. These have now been added so in the future we can return this type and display error messages to the user.