Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add server response type to frontend #875

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

NabbeunNabi
Copy link
Contributor

@NabbeunNabi NabbeunNabi commented Oct 30, 2024

Resolves #877

🔧 What changed

Before we didn't have types that matched our responses from the backend. These have now been added so in the future we can return this type and display error messages to the user.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for findadoc ready!

Name Link
🔨 Latest commit 83ad11c
🔍 Latest deploy log https://app.netlify.com/sites/findadoc/deploys/672a08a276fe9e00083cbcef
😎 Deploy Preview https://deploy-preview-875--findadoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NabbeunNabi NabbeunNabi reopened this Oct 30, 2024
@NabbeunNabi NabbeunNabi self-assigned this Oct 30, 2024
@NabbeunNabi NabbeunNabi added the enhancement New feature or request label Oct 30, 2024
@NabbeunNabi NabbeunNabi changed the title feat: add result type to frontend feat: add server response type to frontend Oct 30, 2024
@NabbeunNabi NabbeunNabi force-pushed the feat/add-result-type-frontend branch from 5332d4c to 7321301 Compare October 30, 2024 23:32
@NabbeunNabi NabbeunNabi marked this pull request as ready for review October 30, 2024 23:38
Copy link
Contributor

@ermish ermish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no errors

@NabbeunNabi NabbeunNabi merged commit b06deeb into main Nov 5, 2024
11 checks passed
@NabbeunNabi NabbeunNabi deleted the feat/add-result-type-frontend branch November 5, 2024 12:08
ProgressChris88 pushed a commit that referenced this pull request Nov 14, 2024
…nForm.

add healthcareprofessionalsection to locales.
create healthcareprofessionalsection cypress test.
add sectionfields to healthcareProfessionalsStore.

Co-authored-by: Chris Bowman <ProgressChris88@users.noreply.github.com>
Co-authored-by: Karl Komeya <karlk08@users.noreply.github.com>
Co-authored-by: NabbeunNabi <williamedwardbrammer@gmail.com>

Co-authored-by: NabbeunNabi <williamedwardbrammer@gmail.com>
Co-authored-by: Matt Keighley <matt@squareonejapan.com>

test: set defaultCommandTimeout to 10000ms for stability (#867)

* test: increase defaultCommandTimeout to 10000ms for stability

Co-authored-by: gminetoma <gminetoma@gmail.com>

* chore: remove unnecessary timeouts in test files

---------

Co-authored-by: gminetoma <gminetoma@gmail.com>

feat: implement mod top bar UI for hp and facility (#865)

chore: update contributors manually (#862)

feat: add mutation to delete existing facility (#847)

Co-authored-by: Philip Ermish <philipermish@gmail.com>

feat: add result type to frontend (#875)

Co-authored-by: Philip Ermish <philipermish@gmail.com>

feat: add mutation to delete healthcare professional (#846)

Add localeFormatting from localeStore to format languages for name locale, spoken languages, and healthcareProfessional's locale. (#879)

Fix healthcareProfessionalName.locale from array to string.

Co-authored-by: Philip Ermish <philipermish@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a ServerResponse type to the frontend
2 participants