Destagger timestamp of each point as well #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…destaggered as well
Samahu
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
@PhilippSchmaelzle you are absolutely right, the timestamp should follow the pixel.
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understand the staggered vs destaggered the time stamp of one column within a staggered image / point cloud is always the same. But in an destaggered image / point cloud represents the same azimuth value in one column.
See here
Therefore i would expect the timestamp of each point in the destaggered point cloud to be corected by the pixel shift as well.
Related Issues & PRs
#188
#60
Summary of Changes
I applied the pixel shift to the timestamp as well
Validation
I tested it with an OS2, FW 2.5.2 with an follow up node for point cloud undistortion and it seem to work.