Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SW-5607: rename package ouster_msgs to avoid package name conflict in ros index #244

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Oct 31, 2023

Related Issues & PRs

Summary of Changes

  • Rename package ouster_msgs to ouster_sensor_msgs to avoid name conflict within ROS index

Validation

N/A

@Samahu Samahu added the enhancement New feature or request label Oct 31, 2023
@Samahu Samahu requested a review from twslankard October 31, 2023 23:09
@Samahu Samahu self-assigned this Oct 31, 2023
@Samahu Samahu changed the title rename package ouster_msgs to avoid conflict name conflict in ros index SW-5607: rename package ouster_msgs to avoid conflict name conflict in ros index Oct 31, 2023
@Samahu Samahu changed the title SW-5607: rename package ouster_msgs to avoid conflict name conflict in ros index SW-5607: rename package ouster_msgs to avoid conflict name in ros index Nov 1, 2023
@Samahu Samahu changed the title SW-5607: rename package ouster_msgs to avoid conflict name in ros index SW-5607: rename package ouster_msgs to avoid package name conflict in ros index Nov 1, 2023
@Samahu Samahu merged commit a8990f9 into ros2 Nov 1, 2023
3 checks passed
@Samahu Samahu deleted the SW-5607-rename-package-ouster-msgs-to-avoid-conflict branch November 1, 2023 12:51
Samahu added a commit that referenced this pull request Nov 1, 2023
commit a8990f9
Author: Ussama Naal <606033+Samahu@users.noreply.github.com>
Date:   Wed Nov 1 14:32:28 2023 +0300

    SW-5607: rename package ouster_msgs to avoid package name conflict in ros index (#244)

    * rename package ouster_msgs to avoid conflict name conflict in ros index
    * set ouster_sensor_msgs version number to match with ouster_ros package

commit 87d6d49
Author: Ussama Naal <606033+Samahu@users.noreply.github.com>
Date:   Tue Sep 12 13:59:11 2023 -0700

    Shutdown when can not connect to sensor on startup in ROS2 (Humble/Iron) (#211)

    * Shutdown when can not connect to sensor on startup
    * Apply same behavior to independent launch file
    * Update changelog and package version
Samahu added a commit that referenced this pull request Nov 1, 2023
commit 81387db
Author: Ussama Naal <ussama.naal@ouster.io>
Date:   Wed Nov 1 06:04:07 2023 -0700

    0.11.1

commit a8a9a10
Author: Ussama Naal <ussama.naal@ouster.io>
Date:   Wed Nov 1 06:03:58 2023 -0700

    Add a forthcoming entry

commit deadb60
Author: Ussama Naal <ussama.naal@ouster.io>
Date:   Wed Nov 1 05:59:15 2023 -0700

    Squashed commit of the following:

    commit a8990f9
    Author: Ussama Naal <606033+Samahu@users.noreply.github.com>
    Date:   Wed Nov 1 14:32:28 2023 +0300

        SW-5607: rename package ouster_msgs to avoid package name conflict in ros index (#244)

        * rename package ouster_msgs to avoid conflict name conflict in ros index
        * set ouster_sensor_msgs version number to match with ouster_ros package

    commit 87d6d49
    Author: Ussama Naal <606033+Samahu@users.noreply.github.com>
    Date:   Tue Sep 12 13:59:11 2023 -0700

        Shutdown when can not connect to sensor on startup in ROS2 (Humble/Iron) (#211)

        * Shutdown when can not connect to sensor on startup
        * Apply same behavior to independent launch file
        * Update changelog and package version

commit 1c8894a
Author: Ussama Naal <ussama.naal@ouster.io>
Date:   Tue Sep 5 10:18:57 2023 -0700

    rolling-0.10.4

commit 5eda338
Author: Ussama Naal <ussama.naal@ouster.io>
Date:   Tue Sep 5 10:17:48 2023 -0700

    reset version to 0.10.3
AchmadFathoni pushed a commit to AchmadFathoni/ouster-ros that referenced this pull request Feb 16, 2024
… ros index (ouster-lidar#244)

* rename package ouster_msgs to avoid conflict name conflict in ros index
* set ouster_sensor_msgs version number to match with ouster_ros package
EirikKolas added a commit to vortexntnu/ouster-lidar-ros2-driver that referenced this pull request Mar 23, 2024
* SW-5607: rename package ouster_msgs to avoid package name conflict in ros index (ouster-lidar#244)

* rename package ouster_msgs to avoid conflict name conflict in ros index
* set ouster_sensor_msgs version number to match with ouster_ros package

* SW-5466: Support Velodyne and other point types in ouster-ros driver (ouster-lidar#216)

* Quick protoype of Velodyne point type
* Add PointXYZIR point type + other major pcl point types
* Include point meta functions and point transform by the ouster_ros namesapce
* Wrap point meta functions with a namespace and use shorter names for the functions +
* Add a seed test module for the point_cloud_compose methods +
 Add description for the point_cloud_compose methods + refactor code and add compile time checks.
* Propagate error state, warn about potential incompatible profile, propagate error state
* Add minimal documentation about the new `point_type` parameter.

* SW-5466: Support Velodyne point type in the ROS driver amendments (ouster-lidar#254)

* Add support to control point_type through launch.xml files +
* Add a note to CHANGELOG about the breaking change for ptp/utc time offset

* SW-5623: Bump up ouster_client to 20231031 release (ouster-lidar#262)

* Bump ouster-client to 2023103 release
* fix: gracefully stop the driver when shutdown is requested.

* ROS-196: laser scan from ros driver is not properly aligned with point cloud [humble] (ouster-lidar#203)

* Apply destagger to laser scan + Add laser to RVIZ
* Align LaserScan with the PointCloud
* Apply proper pixel shift
* Resolve the issue of zeroed laserscan on dual mode
* Address an issue where LaserScan appeared different on FW prior to 2.4
* Fix the issue for odd numbers
* List selected sensors on the main page + Update RVIZ config to highlight the 2D LaserScan.

* Use timeout when waiting for packets to be proceed in case they don't come (ouster-lidar#293)

* docs: fix spelling mistakes (ouster-lidar#296)

---------

Co-authored-by: Ussama Naal <606033+Samahu@users.noreply.github.com>
Co-authored-by: Andre Nguyen <andre-nguyen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants