Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compat): support got #4395

Closed
wants to merge 29 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
0a2fae6
feat(compat): support `got`
paperdave Aug 29, 2023
fc66f3c
add native event emitter test
paperdave Aug 29, 2023
ae77897
alternate approach
paperdave Aug 29, 2023
7c54c38
make js
paperdave Aug 29, 2023
c99a537
got test
paperdave Aug 29, 2023
fecddbf
this test blocks the merge
paperdave Aug 31, 2023
f1c55aa
fix destroy and re add native decompression
cirospaciari Sep 14, 2023
7a5806b
fix got test not running
cirospaciari Sep 14, 2023
6ce6cb8
fix decompress on http
cirospaciari Nov 24, 2023
8bdf68a
remove old files
cirospaciari Nov 24, 2023
9197bba
one more file to remove
cirospaciari Nov 24, 2023
95f32cc
fix tests
cirospaciari Nov 24, 2023
bc1c130
ordered remove on headers
cirospaciari Nov 27, 2023
c310733
Delete `bun_dev_http_server.zig` (#7283)
Jarred-Sumner Nov 25, 2023
8be2195
feat(test): `toHaveBeenCalledWith` and `toHaveBeenLastCalledWith` (#7…
james-elicx Nov 25, 2023
e94ab83
Environment Variables (#7306)
RiskyMH Nov 25, 2023
8697532
fix(Response): single `Content-Range` in http response (#7199)
WingLim Nov 25, 2023
3b795e8
fix(crypto) oneshot Sign and Verify (#7256)
cirospaciari Nov 25, 2023
21c9022
Fix warning
Jarred-Sumner Nov 25, 2023
a211604
Implement `recursive` option in `fs.readdir` (#7296)
Jarred-Sumner Nov 25, 2023
eb17654
fix(node:fs): fix `fs.promises.opendir` not having a `path` property …
samfundev Nov 25, 2023
19cac6b
Update docs (#7193)
Didas-git Nov 25, 2023
65f35d3
Add `import.meta.env` to `bun-types` (#7309)
RiskyMH Nov 25, 2023
f11d07d
Fix assertion failure when Worker is shutting down
Jarred-Sumner Nov 25, 2023
87e0343
Fix bug with readable streams that have been detached (#7308)
Jarred-Sumner Nov 26, 2023
b5a1e71
Clean up lifetime handling for `napi_create_string_utf16` (#7311)
Jarred-Sumner Nov 26, 2023
a43a24f
fix typo (#7327)
Nov 26, 2023
b46f5b5
feat(test): `toHaveBeenNthCalledWith` + improve some fail messages (#…
james-elicx Nov 26, 2023
abeacf2
Fixes #7324 (#7330)
Jarred-Sumner Nov 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix assertion failure when Worker is shutting down
  • Loading branch information
Jarred-Sumner authored and cirospaciari committed Nov 27, 2023
commit f11d07d5762b687fd0d9d9b216fea99e55196563
5 changes: 3 additions & 2 deletions src/bun.js/bindings/ZigGlobalObject.cpp
Original file line number Diff line number Diff line change
@@ -874,8 +874,9 @@ GlobalObject::~GlobalObject()
finalizer(toNapi(this), napiInstanceData, napiInstanceDataFinalizerHint);
}

delete m_subtleCrypto;
scriptExecutionContext()->removeFromContextsMap();
if (auto *ctx = scriptExecutionContext()) {
ctx->removeFromContextsMap();
}
}

void GlobalObject::destroy(JSCell* cell)