-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compat): support got
#4395
Conversation
@paperdave We should add a basic test(s) that include |
✅ test failures on linux-x64-baseline have been resolved. |
✅ test failures on linux-x64 have been resolved. |
❌ @cirospaciari 5 files with test failures on bun-darwin-aarch64:
|
❌ @cirospaciari 6 files with test failures on bun-darwin-x64-baseline:
|
I think, also need tests with https |
test("https gzip", async () => {
const stream = await got('https://bun.sh/', {
headers: {
'Accept-Encoding': 'gzip',
}
});
expect(stream.statusCode).toBe(200);
}); |
the https test does not work and blocks this. looking into it |
* Environment variables * .
* fix: only write header if not exist If user set header by himself, then we not write duplicate header. * feat: add test to check header * chore: format code
* WIP * native oneshot sign * add native verify * fallback rsa to non-native * WIP der dsaEncoding * pass encoding * RSA-PSS padding and saltLength * oopies * improve RSA-PSS support * accepts hash identifiers like nodejs and add options.hashAlgorithm support * fix string check * tests * define hash for ECDSA * fix compilation
* Implement `fs.readdir(path, {recursive: true})` and `fs.readdirSync(path, {recursive: true})` * Update node_fs.zig * FIx memory leak in error code * Add fail test * Update readdir.mjs * Update bun.zig * Update readdir.mjs --------- Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
* Clean up lifetime handling for `napi_create_string_utf16` and `napi_create_string_latin1` * Fix `napi_create_arraybuffer` * Update globals.d.ts --------- Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
…7320) * feat(test): `toHaveBeenNthCalledWith` + improve some fail messages * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Any update on this? I know it's a bad question but got alone has 8.000 dependents. |
Latest error with got 14.3.0
|
Are there any update on this? |
What does this PR do?
I got
got
working.Closes #3150
req.statusMessage
(it is a no-op, which is fine for supporting got, as they do= req.statusMessage ?? http.STATUS_CODES[req.status]
which is already what we set it to.newListeners
in native EE to emit before the listener is added.How did you verify your code works?
Tests for both individual fixes.