Fix E2E IPv6 tests: adapt addresses and subnets #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coveralls is down |
|
/retest |
me too |
|
/lgtm Anyhow IPv6 control-plane tests seem to be disabled again |
Yeah, I realized it yesterday. I will try to re-enable them |
kyrtapz
force-pushed
the
dev_fix_e2e_ipv6
branch
from
9c9d3be
to
488c621
Compare
This commit fixes some previously skipped E2E tests by using an alternative set of addresses and subnets for IPv6 clusters. Signed-off-by: Patryk Diak <pdiak@redhat.com>
kyrtapz
force-pushed
the
dev_fix_e2e_ipv6
branch
from
488c621
to
f48dcf2
Compare
|
/retest |
kyrtapz
force-pushed
the
dev_fix_e2e_ipv6
branch
from
f48dcf2
to
5c042b3
Compare
|
I have not enabled the IPv6 tests in CI after all. Currently we already have a lot of workflows running + it seems that github does not support connecting to external ipv6 addresses from workflows: actions/runner-images#668. I think this PR is ready to be merged and we can address the CI issues separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes some previously skipped E2E tests by using an alternative set of addresses and subnets for IPv6 clusters.
It also enables the control-plane IPv6 tests in a separate commit.
Signed-off-by: Patryk Diak pdiak@redhat.com