-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix E2E IPv6 tests: adapt addresses and subnets #2505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Coveralls is down |
/retest |
me too |
/lgtm Anyhow IPv6 control-plane tests seem to be disabled again |
Yeah, I realized it yesterday. I will try to re-enable them |
9c9d3be
to
488c621
Compare
This commit fixes some previously skipped E2E tests by using an alternative set of addresses and subnets for IPv6 clusters. Signed-off-by: Patryk Diak <pdiak@redhat.com>
488c621
to
f48dcf2
Compare
/retest |
f48dcf2
to
5c042b3
Compare
I have not enabled the IPv6 tests in CI after all. Currently we already have a lot of workflows running + it seems that github does not support connecting to external ipv6 addresses from workflows: actions/runner-images#668. I think this PR is ready to be merged and we can address the CI issues separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This commit fixes some previously skipped E2E tests by using an alternative set of addresses and subnets for IPv6 clusters.
It also enables the control-plane IPv6 tests in a separate commit.
Signed-off-by: Patryk Diak pdiak@redhat.com