Run ipv6 lane in control plane jobs #3512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh great, we have a bunch of them failing.. did we never do v6 lanes in control-plane before? |
|
Failing tests are:
this test is skipped for V6? so why is it being run?! :/
|
|
unit test failure related to #3490 |
|
/retest-failed |
|
/retest-failed |
tssurya
force-pushed
the
run-ipv6-lanes
branch
2 times, most recently
from
97e78cd
to
4861270
Compare
|
/retest-failed |
|
/retest-failed |
tssurya
force-pushed
the
run-ipv6-lanes
branch
2 times, most recently
from
289081a
to
931c078
Compare
This commit fixes things here and there in e2e's to make control planes run on v6 as well. Note that some tests are skipped since they cannot be run on github runners with v6 enabled. NOTE: One of the multicast test is moved from e2e.go to multicast.go where it belongs. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What this PR does and why is it needed
I was trying to review #3503 (that got merged already so too late) but then was thinking why this wasn't caught in CI and @trozet pointed out that we are indeed not running v6 in control plane? LOL. I swear we used to.. Wondering at which point this changed, either ways don't want to git blame. Let's fix that.
- Special notes for reviewers
NOTE: Some of these tests that check connectivity to internet cannot be run. See actions/runner-images#668 (comment) for details.
There were some past efforts to re-enable some of these skipped tests, but that never happened and they are
still failing v6 lane: #2505, #2524, #2287; #2276; so going to skip them again.
- How to verify it
- Description for the changelog