Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit option for explorers redirects to a broken link #4033

Closed
paarriagadap opened this issue Oct 8, 2024 · 1 comment · Fixed by #4105
Closed

Edit option for explorers redirects to a broken link #4033

paarriagadap opened this issue Oct 8, 2024 · 1 comment · Fixed by #4105
Assignees
@danyx23
Labels
bug explorers priority 3 - nice to have

Comments

@paarriagadap
Copy link

Description

The Edit option available from a live explorer view shows a broken link in the form https://ourworldindata.org/undefined/admin/explorers/name-of-explorer

Expected behaviour

The link should be something like https://admin.owid.io/admin/explorers/name-of-explorer

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to https://ourworldindata.org/explorers/poverty-explorer
  2. Click on the share icon
  3. Click on Edit
  4. See 404 page: https://ourworldindata.org/explorers/undefined/admin/explorers/poverty-explorer

Screenshots

The Edit option is available by pressing the share button:
Image

Environment

For desktop, provide:

  • OS: macOS Sequoia 15.0.1
  • Browser: Google Chrome
  • Version 129.0.6668.90 (Official Build) (arm64)
@rakyi rakyi mentioned this issue Oct 8, 2024
Closed
@sophiamersmann
Copy link
Member

Would make sense to tackle this when working on #3987

@danyx23 danyx23 self-assigned this Nov 3, 2024
@danyx23 danyx23 linked a pull request Nov 4, 2024 that will close this issue
🔨 Fix explorer edit button #4105
Merged
@danyx23 danyx23 mentioned this issue Nov 4, 2024
Merged
danyx23 added a commit that referenced this issue Nov 14, 2024
@danyx23
🔨 Fix explorer edit button (#4105)
bf8b333 
This PR fixes the bug reported in #4033 where the edit button in the share menu of grapher does not point to the right location for explorers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danyx23 danyx23

Labels
bug explorers priority 3 - nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔨 Fix explorer edit button owid/owid-grapher
3 participants
@danyx23 @sophiamersmann @paarriagadap