Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mdims: Remove the hack to open the indicator chart admin when clicking on edit in the share menu #3987

Closed
Tracked by #3877
, #4007
...
danyx23 opened this issue Sep 30, 2024 · 2 comments · Fixed by #4104
Closed
Tracked by #3877
, #4007
...

Mdims: Remove the hack to open the indicator chart admin when clicking on edit in the share menu #3987

danyx23 opened this issue Sep 30, 2024 · 2 comments · Fixed by #4104
Assignees
@danyx23
Labels
site

Comments

@danyx23
Copy link
Contributor

danyx23 commented Sep 30, 2024 •
edited
Loading

In #3950 Daniel added a quick hack to enable navigating to the indicator chart admin when looking at an MDim and clicking on share -> edit.

This workflow makes it a lot easier to tweak Mdim views but we should solve it properly.
@danyx23 danyx23 mentioned this issue Sep 30, 2024
Closed
4 tasks
@danyx23 danyx23 mentioned this issue Oct 4, 2024
Closed
6 tasks
@danyx23 danyx23 changed the title Remove the hack to open the indicator chart admin when clicking on edit in the share menu Mdims: Remove the hack to open the indicator chart admin when clicking on edit in the share menu Oct 4, 2024
@danyx23 danyx23 added site and removed needs triage labels Oct 4, 2024
@rakyi
Copy link
Contributor

rakyi commented Oct 8, 2024

#4033 might be related.

@sophiamersmann sophiamersmann mentioned this issue Oct 9, 2024
Closed
@danyx23 danyx23 assigned danyx23 and unassigned rakyi Nov 3, 2024
@danyx23 danyx23 mentioned this issue Nov 4, 2024
Merged
@danyx23 danyx23 linked a pull request Nov 4, 2024 that will close this issue
🔨 fix the mdim edit hack #4104
Merged
@larsyencken
Copy link
Contributor

@danyx23 Since this one has an open PR, carrying it through to the current cycle.

danyx23 added a commit that referenced this issue Nov 14, 2024
@danyx23
🔨 fix the mdim edit hack (#4104)
c8058b1 
Fixes the hack to make the internal edit link in the share menu of grapher work for Mdims (#3987)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danyx23 danyx23

Labels
site
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔨 fix the mdim edit hack owid/owid-grapher
3 participants
@larsyencken @danyx23 @rakyi