🔨 fix the mdim edit hack #4104
Merged
🔨 fix the mdim edit hack #4104
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-11-04 10:12:26 UTC |
danyx23
force-pushed
the
fix-mdim-edit-hack
branch
2 times, most recently
from
9fa24fa to
4cf6efb
Compare
danyx23
force-pushed
the
fix-mdim-edit-hack
branch
2 times, most recently
from
cd7bcf8 to
76b50b2
Compare
marcelgerber
reviewed
Nov 6, 2024
Comment on lines
+283
to
+297
| variables?.length === 1 | ||
| ? `variables/${variables[0]}/config` | ||
| : undefined |
There was a problem hiding this comment.
Hm, this will mean that if there is more than a single y variable, the URL will still be wrong...
There was a problem hiding this comment.
Yeah - do you think it's worthwhile turning editUrl into an object so we can communicate "do not show any edit link"?
danyx23
force-pushed
the
fix-mdim-edit-hack
branch
from
76b50b2 to
4575974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the hack to make the internal edit link in the share menu of grapher work for Mdims (#3987)