🔨 (db) add chart_configs table / TAS-563

[sophiamersmann]

Summary

Adds a chart_configs table to the database, adds a configId column to the charts table that points to a chart_configs row, and removes the config column.

Shouldn't result in any functionality change.

Details

• All configs are copied from the charts table to the chart_configs table (for now, patch config = full config since inheritance hasn't been implemented yet)
• Configs have a UUID, but it's not yet used (the id of the chart is still the sequential primary key of the charts table)

Testing

• Bakes locally
• Bakes staging site

Site:

• http://staging-site-db-chart-configs/
• http://staging-site-db-chart-configs/grapher/life-expectancy
• http://staging-site-db-chart-configs/explorers/coronavirus-data-explorer
• http://staging-site-db-chart-configs/explorers/democracy
• http://staging-site-db-chart-configs/explorers/conflict-data
• http://staging-site-db-chart-configs/poverty
• http://staging-site-db-chart-configs/financing-education
• http://staging-site-db-chart-configs/part-two-how-many-people-die-from-extreme-temperatures-and-how-could-this-change-in-the-future
• http://staging-site-db-chart-configs/covid-hospitalizations
• http://staging-site-db-chart-configs/country/germany
• http://staging-site-db-chart-configs/energy/country/india
• http://staging-site-db-chart-configs/data-insights
• http://staging-site-db-chart-configs/collection/top-charts
• http://staging-site-db-chart-configs/sdgs
• http://staging-site-db-chart-configs/sdgs/no-poverty

Admin:

• Chart editor:
  • Create new chart
  • Save as new chart
  • Update existing chart
  • Publish chart
  • Unpublish chart
  • Delete chart
• Bulk chart editor
• Chart test page
• Variable page (chart list)

On the ETL side

Mojmir opened a PR for changes to the ETL: owid/etl#2957

To do

• Is it safe to rewrite the config's id? I think it's okay
• I don't understand why we manually insert createdAt and updatedAt since the db inserts values on insert/update?
• Checklist for updating the db: https://www.notion.so/owid/Database-access-in-Grapher-d9db343c2bfb4ae0b14b3dec72f686c6?pvs=4#dd5b51bab6f84630839f4173b59feba2
• Let Mojmir know so that he can update the ETL db schema (wait for the table structure to be signed off on)

To do after merging

• ETL: 🔨 Move chart configs into chart_configs table etl#2957
• Datasette: https://github.com/owid/analytics/pull/138
• Schema validation: https://github.com/owid/automation/pull/12

[sophiamersmann]

• 🔨 (db) add chart_configs table / TAS-563 #3767 : 2 dependent PRs (#3743 , #3782 ) 👈
• 🔨 Add wrangler.toml file #3846
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite

[owidbot]

Quick links (staging server):

Site	Admin	Wizard

Login: ssh owid@staging-site-db-chart-configs

• Site-screenshots: https://github.com/owid/site-screenshots/compare/db-chart-configs
• SVG tester: https://github.com/owid/owid-grapher-svgs/compare/db-chart-configs

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-07-08 14:35:44 UTC
Execution time: 1.19 seconds

[danyx23]

Looks good overall! I think we should add the slug as a materialized computed column on chart_configs for now and add an index - even if we move it back to chart eventually. We use this quite extensively and loosing the ability to use an index could hurt performance quite a bit, especially if we start pushing more and more stuff into chart_configs later in the cycle.

[danyx23]

Just to note that I haven't run this locally yet - the PR review so far was just about looking at the code. Ping me again when you are ready and then I'll run through the migration and QA the code a bit more :)

[notion-workspace]

Add charts_config table to the DB

[sophiamersmann]

Merge activity

• Sep 3, 3:24 AM EDT: @sophiamersmann started a stack merge that includes this pull request via Graphite.
• Sep 3, 3:25 AM EDT: @sophiamersmann merged this pull request with Graphite.