🔨 Add wrangler.toml file

[danyx23]

This PR adds a wrangler.toml file to the grapher repo for the pages functions. It should be a NO-OP in terms of functionality. It's added mostly so that we can use the toml file to add per-environment specific variables or bindings in the future.

[danyx23]

• 🔨 (db) add chart_configs table / TAS-563 #3767 : 2 dependent PRs (#3743 , #3782 )
• 🔨 Add wrangler.toml file #3846 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danyx23 and the rest of your teammates on Graphite

[owidbot]

Quick links (staging server):

Site	Admin	Wizard

Login: ssh owid@staging-site-enable-wrangler-toml

• Site-screenshots: https://github.com/owid/site-screenshots/compare/enable-wrangler-toml
• SVG tester: https://github.com/owid/owid-grapher-svgs/compare/enable-wrangler-toml

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-08-09 16:03:31 UTC
Execution time: 1.21 seconds

[danyx23]

I ran deployContentPreview and checked that the thumbnail worker there still does what it should: https://enable-wrangler-toml.owid-staging.pages.dev/grapher/thumbnail/life-expectancy

I think it should be safe to merge this but when we do we should be vigilant in case there is some config weirdness in prod that isn't present in staging

[marcelgerber]

Suggested change

	return new Response(JSON.stringify(info), {
	headers: { "Content-Type": "application/json" },
	})
	return Response.json(info)

[danyx23]

@marcelgerber I squashed the changes now of this PR and removed the debug code again. The settings from wrangler.toml showed up in the dashboard for the preview now which is nice - only the secrets are still managed via the dashboard (which makes sense).

On staging, some settings for dev keys were not set as secrets and with the introduction of wrangler.toml they then vanished (as they are not in wrangler.toml either). Since they should have been configured as secrets anyhow, I made sure to add the dev keys as secrets for the preview deployment in the CF dashboard. On prod, everything looks good (i.e. everything is configured as secrets except for the three vars that are set in wrangler.toml.

As we discussed, since the preview deployment to CF and the prod deploy use the same mechanism and "./dist" folder, I think this should be good to go.

I'd appreciate a quick look over it as a sanity check then we can finally merge this one :)

[marcelgerber]

Nice, looks good!

[danyx23]

Merge activity

• Aug 13, 12:40 PM EDT: @danyx23 started a stack merge that includes this pull request via Graphite.
• Aug 13, 12:40 PM EDT: @danyx23 merged this pull request with Graphite.