replace mrclay/minify with JShrink (#13052) #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2015
mrclay/minify is present only to provide the 'JSMin' minifier, but this is non-free. JShrink is free, it's also a currently maintained project following good development practices, and not tied to a bundle of other junk like mrclay/minify. This commit goes along with a commit to owncloud itself to switch from using Assetic's JSMin filter to its JShrink filter.
|
Thanks a lot @AdamWill - can you please add tedivm/jshrink/tests to .gitignore? THX |
|
let's go for JSqueeze |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mrclay/minify is present only to provide the 'JSMin' minifier, but this is non-free. JShrink is free, it's also a currently maintained project following good development practices, and not tied to a bundle of other junk like mrclay/minify. This commit goes along with a commit to owncloud itself to switch from using Assetic's JSMin filter to its JShrink filter: owncloud/core#13185
NOTE: this is inappropriate unless owncloud/core#13185 is merged, and would break ownCloud.