use JShrink instead of JSMin (#13052) #13185
Conversation
The JSMin minifier is non-free. JShrink is free, it's also a currently-maintained project following good development practices (though we may wish to switch to JSqueeze soon for performance reasons; waiting on kriswallsmith/assetic#698 reaching upstream Assetic 1.2 for that). This goes along with a 3rdparty commit that drops mrclay/minify and adds JShrink.
|
Thanks a lot for your contribution! Contributions to the core repo require a signed contributors agreement http://owncloud.org/contribute/agreement/ Alternatively you can add a comment here stating that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/ |
|
The inspection completed: No new issues |
|
JShrinkFilter is missing - we could add this right next to SeparatorFilter in lib/private/assetic |
|
Gah, you're right - I'd forgotten about that in the damn shrinker merry-go-round. If we have to twiddle Assetic anyway we may as well just go straight to JSqueeze, I guess? I'll send a different PR in a bit. |
|
#13229 is an alternative which uses JSqueeze instead of JShrink; as we'd have to mess with Assetic either way, my personal preference would be just to go straight to JSqueeze. |
|
let's go for JSqueeze |
The JSMin minifier is non-free. JShrink is free, it's also a currently-maintained project following good development practices (though we may wish to switch to JSqueeze soon for performance reasons; waiting on
kriswallsmith/assetic#698 reaching upstream Assetic 1.2 for that). This goes along with owncloud-archive/3rdparty#149 , a 3rdparty PR that drops mrclay/minify and adds JShrink.
NOTE: this will fail without the matching 3rdparty commit, as JShrink will not be available.