Add missing public link share dialog features

[felixheidecke]

Description

• Size of the modal itself may not change when multiple (long) mail addresses are entered (it even changes when selecting the input field and selecting another item in the dialog)
• Move "Share" button to the right, "Cancel" to the left. The current order seems not intuitive.
• E-mail validation should be added (currently select2 takes all values; you can even just enter spaces): name@domain.tld
• Multiple mail recipients should not be able to see the other recipient's mail addresses. Therefore we should not put all mail addresses in the "To" field but in "BCC". @PVince81
• "Send copy to self" does not work at all (mails are only sent to the recipients). No ability to receive a copy, tried various scenarios. @PVince81
• "E-Mail sent" has been removed. It was an explicit requirement to show "E-Mail sent" longer for that the user actually has a chance to read it.
• Public link sendmail: "Sending" is now green, but the actual idea was to have the success message "E-Mail sent" green (which has been removed!)
• "Sending" now seems to have a delay of 2 seconds until it disappears. This was the idea for the "E-Mail sent" indicator.

Related Issue

Fixes: #31125

How Has This Been Tested?

Manually tested in FF, Chrome and IE11

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #31129 into master will increase coverage by <.01%.
The diff coverage is 76%.

@@             Coverage Diff              @@
##             master   #31129      +/-   ##
============================================
+ Coverage     62.51%   62.52%   +<.01%     
- Complexity    18272    18274       +2     
============================================
  Files          1146     1147       +1     
  Lines         68405    68428      +23     
  Branches       1234     1234              
============================================
+ Hits          42766    42787      +21     
- Misses        25278    25280       +2     
  Partials        361      361

Flag	Coverage Δ	Complexity Δ
#javascript	52.05% <100%> (+0.02%)	0 <0> (ø)	⬇️
#phpunit	63.72% <45.45%> (ø)	18274 <1> (+2)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
core/ajax/share.php	0% <0%> (ø)	0 <0> (ø)	⬇️
core/js/sharedialoglinkshareview.js	82.05% <100%> (ø)	0 <0> (ø)	⬇️
core/js/sharedialogmailview.js	60.39% <100%> (+1.21%)	0 <0> (ø)	⬇️
lib/private/Share/MailNotifications.php	90.74% <100%> (+0.17%)	29 <1> (+1)	⬆️
apps/files/lib/Service/TagService.php	95% <0%> (-5%)	6% <0%> (+1%)
apps/files/lib/AppInfo/Application.php	39.02% <0%> (-0.98%)	7% <0%> (-1%)
lib/private/PreviewManager.php	50% <0%> (-0.77%)	50% <0%> (+1%)
core/templates/lostpassword/email.php	100% <0%> (ø)	0% <0%> (ø)	⬇️
core/templates/lostpassword/altemail.php	100% <0%> (ø)	0% <0%> (?)
lib/private/Server.php	85.05% <0%> (+0.03%)	254% <0%> (ø)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edfc66a...9534390. Read the comment docs.

[felixheidecke]

I need help debugging PHP code, trying to bcc self in the modal and checking why it won't go thru:

Step 1: https://github.com/owncloud/core/blame/fix-31125/core/ajax/share.php#L185
Step 2: https://github.com/owncloud/core/blame/fix-31125/lib/private/Share/MailNotifications.php#L198

Reproduce: Make sure to have an email set to your account and enable Allow users to send mail notification for shared files in the sharing options. Then share via mail:

[felixheidecke]

Alright … I figured it out myself. Hope I didn't break stuff 😅

[PVince81]

all recipient mail now in BCC field, including self when ticked

[PVince81]

👍 for Felix' part.

[felixheidecke]

For @PVince81 part.

[PVince81]

@felixheidecke please backport to stable10

[felixheidecke]

Backport #31142

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.