[stable10] Add missing public link share dialog features

[felixheidecke]

Description

• Size of the modal itself may not change when multiple (long) mail addresses are entered (it even changes when selecting the input field and selecting another item in the dialog)
• Move "Share" button to the right, "Cancel" to the left. The current order seems not intuitive.
• E-mail validation should be added (currently select2 takes all values; you can even just enter spaces): name@domain.tld
• Multiple mail recipients should not be able to see the other recipient's mail addresses. Therefore we should not put all mail addresses in the "To" field but in "BCC". @PVince81
• "Send copy to self" does not work at all (mails are only sent to the recipients). No ability to receive a copy, tried various scenarios. @PVince81
• "E-Mail sent" has been removed. It was an explicit requirement to show "E-Mail sent" longer for that the user actually has a chance to read it.
• Public link sendmail: "Sending" is now green, but the actual idea was to have the success message "E-Mail sent" green (which has been removed!)
• "Sending" now seems to have a delay of 2 seconds until it disappears. This was the idea for the "E-Mail sent" indicator.

Related Issue

Fixes: #31125

How Has This Been Tested?

Manually tested in FF, Chrome and IE11

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[felixheidecke]

Backporting #31129

[PVince81]

Did a quick test, sending emails still work and the design looks like on master 👍

[codecov]

Codecov Report

Merging #31142 into stable10 will increase coverage by <.01%.
The diff coverage is 76%.

@@              Coverage Diff               @@
##             stable10   #31142      +/-   ##
==============================================
+ Coverage       60.14%   60.14%   +<.01%     
- Complexity      18174    18175       +1     
==============================================
  Files            1194     1194              
  Lines           71706    71710       +4     
  Branches         1248     1248              
==============================================
+ Hits            43124    43129       +5     
+ Misses          28212    28211       -1     
  Partials          370      370

Flag	Coverage Δ	Complexity Δ
#javascript	52.67% <100%> (+0.02%)	0 <0> (ø)	⬇️
#phpunit	60.96% <45.45%> (ø)	18175 <1> (+1)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
core/ajax/share.php	0% <0%> (ø)	0 <0> (ø)	⬇️
core/js/sharedialoglinkshareview.js	82.05% <100%> (ø)	0 <0> (ø)	⬇️
core/js/sharedialogmailview.js	60.39% <100%> (+1.21%)	0 <0> (ø)	⬇️
lib/private/Share/MailNotifications.php	90.9% <100%> (+0.16%)	29 <1> (+1)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57761f9...776bd22. Read the comment docs.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.