feat(linter): add fixer for eslint/func_names #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Aug 6, 2024
DonIsaac
force-pushed
the
don/08-05-fix_linter/func-names_handle_ts_accessibility_when_reporting_missing_names
branch
from
9647590 to
6ac064c
Compare
DonIsaac
force-pushed
the
don/08-06-feat_linter_add_fixer_for_eslint/func_names
branch
from
6072878 to
41d0690
Compare
DonIsaac
force-pushed
the
don/08-05-fix_linter/func-names_handle_ts_accessibility_when_reporting_missing_names
branch
from
6ac064c to
85de59a
Compare
DonIsaac
force-pushed
the
don/08-06-feat_linter_add_fixer_for_eslint/func_names
branch
from
41d0690 to
335da8e
Compare
CodSpeed Performance ReportMerging #4714 will not alter performanceComparing Summary
|
DonIsaac
force-pushed
the
don/08-06-feat_linter_add_fixer_for_eslint/func_names
branch
from
335da8e to
30655f7
Compare
mysteryven
force-pushed
the
don/08-05-fix_linter/func-names_handle_ts_accessibility_when_reporting_missing_names
branch
from
85de59a to
7d1dd97
Compare
mysteryven
force-pushed
the
don/08-06-feat_linter_add_fixer_for_eslint/func_names
branch
from
30655f7 to
7bb6559
Compare
mysteryven
reviewed
Aug 7, 2024
Merge activity
|
Boshen
changed the base branch from
don/08-05-fix_linter/func-names_handle_ts_accessibility_when_reporting_missing_names
to
graphite-base/4714
Boshen
force-pushed
the
don/08-06-feat_linter_add_fixer_for_eslint/func_names
branch
from
7bb6559 to
c1be6e8
Compare
DonIsaac
force-pushed
the
don/08-06-feat_linter_add_fixer_for_eslint/func_names
branch
2 times, most recently
from
250037b to
3099377
Compare
Boshen
force-pushed
the
don/08-06-feat_linter_add_fixer_for_eslint/func_names
branch
from
3099377 to
eaddc8f
Compare
graphite-app
bot
deleted the
don/08-06-feat_linter_add_fixer_for_eslint/func_names
branch
Merged
Boshen
added a commit
that referenced
this pull request
Aug 8, 2024
## [0.24.0] - 2024-08-08 - 75f2207 traverse: [**BREAKING**] Replace `find_scope` with `ancestor_scopes` returning iterator (#4693) (overlookmotel) - 506709f traverse: [**BREAKING**] Replace `find_ancestor` with `ancestors` returning iterator (#4692) (overlookmotel) ### Features - 23b0040 allocator: Introduce `CloneIn` trait. (#4726) (rzvxa) - 51c1ca0 ast: Derive `CloneIn` for AST types, using `generate_derive`. (#4732) (rzvxa) - e12bd1e ast: Allow conversion from TSAccessibility into &'static str (#4711) (DonIsaac) - fd2d9da ast: Improve `AstKind::debug_name` (#4553) (DonIsaac) - b3b7028 ast: Implement missing Clone, Hash, and Display traits for literals (#4552) (DonIsaac) - 54047e0 ast: `GetSpanMut` trait (#4609) (overlookmotel) - eae401c ast, ast_macros: Apply stable repr to all `#[ast]` enums (#4373) (rzvxa) - ec0b4cb ast_codegen: Add `derive_clone_in` generator. (#4731) (rzvxa) - 2e91ad6 ast_codegen: Support for `generate_derive` marker. (#4728) (rzvxa) - 82e2f6b ast_codegen: Process AST-related `syntax` types. (#4694) (rzvxa) - 0c52c0d ast_codegen: Add alignment and size data to the schema. (#4615) (rzvxa) - 07607d3 ast_codegen, span: Process `Span` through ast_codegen (#4703) (overlookmotel) - 125c5fd ast_codegen, span: Process `SourceType` through ast_codegen. (#4696) (rzvxa) - eaddc8f linter: Add fixer for eslint/func_names (#4714) (DonIsaac) - 229a0e9 minifier: Implement dot define for member expressions (#3959) (camc314) - 33f1312 semantic: Impl GetSpan for AstNode (#4717) (DonIsaac) - e42ac3a sourcemap: Add `ConcatSourceMapBuilder::from_sourcemaps` (#4639) (overlookmotel) - 2e63618 span: Implement `CloneIn` for the AST-related items. (#4729) (rzvxa) - 6a36616 syntax: Derive `CloneIn` for the AST-related items. (#4730) (rzvxa) ### Bug Fixes - 4a56954 codegen: Print raw if value is number is Infinity (#4676) (Boshen) - 94d3c31 minifier: Avoid removing function declaration from `KeepVar` (#4722) (Boshen) - bf43148 minifier: Do not `remove_syntax` in dead_code_elimination (Boshen) - bf48c7f minifier: Fix `keep_var` keeping vars from arrow functions (#4680) (Boshen) - 9be29af minifier: Temporarily fix shadowed `undefined` variable (#4678) (Boshen) - e8b662a minifier: Various fixes to pass minifier conformance (#4667) (Boshen) - 01d85de napi/transform: Update napi files (Boshen) - f290191 oxc_ast_macros: Fix `syn` lacking features to build (Boshen) - a40a217 parser: Parse `assert` keyword in `TSImportAttributes` (#4610) (Boshen) - 03c643a semantic: Incorrect `scope_id` for catch parameter symbols (#4659) (Dunqing) - 6c612d1 semantic/jsdoc: Handle whitespace absence (#4642) (leaysgur) - 0d2c41a semantic/jsdoc: Panic on parsing `type_name_comment`. (#4632) (rzvxa) - 9f8f299 syntax: Prevent creating invalid u32 IDs (#4675) (overlookmotel) - 4797eaa transformer: Strip TS statements from for in/of statement bodies (#4686) (overlookmotel) - 5327acd transformer/react: The `require` IdentifierReference does not have a `reference_id` (#4658) (Dunqing) - 3987665 transformer/typescript: Incorrect enum-related `symbol_id`/`reference_id` (#4660) (Dunqing) - 4efd54b transformer/typescript: Incorrect `SymbolFlags` for jsx imports (#4549) (Dunqing) ### Performance - 8dd76e4 codegen: Reduce size of `LineOffsetTable` (#4643) (overlookmotel) - b8e6753 codegen: `u32` indexes in `LineOffsetTable` for source maps (#4641) (overlookmotel) - 6ff200d linter: Change react rules and utils to use `Cow` and `CompactStr` instead of `String` (#4603) (DonIsaac) - 0f5e982 minifier: Only visit arrow expression after dropping `console.log` (#4677) (Boshen) - ff43dff sourcemap: Speed up VLQ encoding (#4633) (overlookmotel) - a330773 sourcemap: Reduce string copying in `ConcatSourceMapBuilder` (#4638) (overlookmotel) - 372316b sourcemap: `ConcatSourceMapBuilder` extend `source_contents` in separate loop (#4634) (overlookmotel) - c7f1d48 sourcemap: Keep local copy of previous token in VLQ encode (#4596) (overlookmotel) - 590d795 sourcemap: Shorten main loop encoding VLQ (#4586) (overlookmotel) ### Documentation - c69ada4 ast: Improve AST node documentation (#4051) (Rintaro Itokawa) ### Refactor - 579b797 ast: Use type identifier instead of `CloneIn::Cloned` GAT. (#4738) (rzvxa) - 475266d ast: Use correct lifetimes for name-related methods (#4712) (DonIsaac) - 83b6ca9 ast: Add explicit enum discriminants. (#4689) (rzvxa) - ba70001 ast: Put `assert_layouts.rs` behind `debug_assertions` (#4621) (rzvxa) - 3f53b6f ast: Make AST structs `repr(C)`. (#4614) (rzvxa) - 452e0ee ast: Remove defunct `visit_as` + `visit_args` attrs from `#[ast]` macro (#4599) (overlookmotel) - 2218340 ast, ast_codegen: Use `generate_derive` for implementing `GetSpan` and `GetSpanMut` traits. (#4735) (rzvxa) - fbfd852 minifier: Add `NodeUtil` trait for accessing symbols on ast nodes (#4734) (Boshen) - e0832f8 minifier: Use `oxc_traverse` for AST passes (#4725) (Boshen) - 17602db minifier: Move tests and files around (Boshen) - 3289477 minifier: Clean up tests (#4724) (Boshen) - e78cba6 minifier: Ast passes infrastructure (#4625) (Boshen) - d25dea7 parser: Use `ast_builder` in more places. (#4612) (rzvxa) - 09d9822 semantic: Simplify setting scope flags (#4674) (overlookmotel) - 6e453db semantic: Simplify inherit scope flags from parent scope (#4664) (Dunqing) - e1429e5 span: Reduce #[cfg_attr] boilerplate in type defs (#4702) (overlookmotel) - e24fb5b syntax: Add explicit enum discriminants to AST related types. (#4691) (rzvxa) - 3f3cb62 syntax, span: Reduce #[cfg_attr] boilerplate in type defs (#4698) (overlookmotel) - 54f9897 traverse: Simpler code for entering/exiting unconditional scopes (#4685) (overlookmotel) - 83546d3 traverse: Enter node before entering scope (#4684) (overlookmotel)- 9b51e04 Overhaul napi transformer package (#4592) (DonIsaac) ### Testing - 49d5196 ast: Fix `assert_layouts.rs` offset tests on 32bit platforms. (#4620) (rzvxa) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Merged
Boshen
added a commit
that referenced
this pull request
Aug 12, 2024
## [0.7.1] - 2024-08-12 ### Features - 3d40528 linter: Add fix emoji to rules table and doc pages (#4715) (DonIsaac) - d2734f3 linter: Start fixer for no-unused-vars (#4718) (DonIsaac) - 070ae53 linter: Add fixer for unicorn prefer-string-replace-all (#4801) (camc314) - b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac) - 5992b75 linter: Implement `eslint-plugin-promise/no-return-in-finally, prefer-await-to-then` rule (#4318) (Jelle van der Waa) - b259f47 linter: Add fixer for unicorn/no-length-as-slice-end (#4780) (heygsc) - abd83fa linter: Add fixer for jsx_ally/no_aria_hidden_on_focusable (#4772) (heygsc) - b20e335 linter: Add fixer for eslint/no-eq-null (#4758) (heygsc) - 2f6c3b9 linter: Add fixer for eslint/no-compare-neg-zero (#4748) (heygsc) - eaddc8f linter: Add fixer for eslint/func_names (#4714) (DonIsaac) - 80557a9 linter: Add fixer for eslint/for-direction (#4679) (heygsc) - c3c5766 linter/eslint-plugin-promise: Implement valid-params (#4598) (Jelle van der Waa) - c509a21 linter/eslint-plugin-vitest: Implement prefer-to-be-falsy (#4770) (dalaoshu) - 41f861f linter/eslint-plugin-vitest: Implement prefer-to-be-truthy (#4755) (dalaoshu) - cc922f4 vscode: Provide config's schema to oxlint config files (#4826) (Don Isaac) - f629514 website: Auto-generate rule docs pages (#4640) (DonIsaac) ### Bug Fixes - b22ed45 linter: Improve prefer_namespace_keyword rule (#4751) (Burlin) - db68a6c linter: Fixer for eslint/for-direction (#4727) (heygsc) - 6273994 linter: Block in eslint/no_cond_assign (#4721) (heygsc) - b9d6aa5 linter: Fix false positives in no-confusing-non-null-assertion (#4665) (Renée) - cbf08d2 linter: Skip no-multi-str on jsx attributes (#4666) (heygsc) - a6f9f96 linter: No unused errors should be warnings (Boshen) - 7345bc9 linter/func-names: Handle ts accessibility when reporting missing names (#4713) (DonIsaac) ### Performance - d191823 linter: Optmize allocations in jest fn parsing (#4787) (lucab) - e3abdfa linter: Reduce String allocations and clones (#4673) (DonIsaac) ### Documentation - 4b7dfd6 linter: Correct docs for no-unused-vars (#4716) (Don Isaac) ### Refactor - 096ac7b linter: Clean up jsx-a11y/anchor-is-valid (#4831) (DonIsaac) - 15a0fd4 linter: Use Option to reduce nested level in `eslint/getter-return` (#4814) (IWANABETHATGUY) - 63f274c linter: Simplify NoObjCalls resolution logic (#4765) (lucab) - 6708680 linter: Replace Windows-style line breaks with Unix-style in test fixture (#4768) (overlookmotel) - e285903 linter: Clean up eslint/func_names (#4710) (DonIsaac) ### Testing - 8f2a566 linter: Ensure rule docs have valid syntax (#4644) (DonIsaac) - 4dd29db linter: Add fixer test for unicorn/no-zero-fractions (#4783) (heygsc) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.