feat(linter): start fixer for no-unused-vars #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 7, 2024
DonIsaac
force-pushed
the
don/08-06-feat_semantic_impl_getspan_for_astnode
branch
from
2ea9e94
to
f40a09c
Compare
DonIsaac
force-pushed
the
don/08-06-feat_linter_start_fixer_for_no-unused-vars
branch
from
9a34ba7
to
cc1be9a
Compare
DonIsaac
force-pushed
the
don/08-06-feat_semantic_impl_getspan_for_astnode
branch
from
f40a09c
to
3ef9237
Compare
DonIsaac
force-pushed
the
don/08-06-feat_linter_start_fixer_for_no-unused-vars
branch
from
cc1be9a
to
cb3dce8
Compare
CodSpeed Performance ReportMerging #4718 will not alter performanceComparing Summary
|
Boshen
changed the base branch from
don/08-06-feat_semantic_impl_getspan_for_astnode
to
graphite-base/4718
Boshen
force-pushed
the
don/08-06-feat_linter_start_fixer_for_no-unused-vars
branch
from
cb3dce8
to
b69bc8b
Compare
DonIsaac
force-pushed
the
don/08-06-feat_linter_start_fixer_for_no-unused-vars
branch
4 times, most recently
from
ff2a55a
to
7b84363
Compare
DonIsaac
force-pushed
the
don/08-06-feat_linter_start_fixer_for_no-unused-vars
branch
from
7b84363
to
7ccfce1
Compare
DonIsaac
commented
Aug 9, 2024
|
I'll take a close look tonight! |
mysteryven
approved these changes
Aug 10, 2024
Merge activity
|
Start to add dangerous suggestions for `no-unused-vars`. This PR focuses on fixing unused variable declarations. - declarations with no references of any kind will be removed with a `FixKind` of dangerous suggestion. - declarations with some usages will be renamed when the rule is configured with certain `"varsIgnorePattern"`s with a `FixKind` of dangerous fix.
mysteryven
force-pushed
the
don/08-06-feat_linter_start_fixer_for_no-unused-vars
branch
from
7ccfce1
to
d2734f3
Compare
graphite-app
bot
deleted the
don/08-06-feat_linter_start_fixer_for_no-unused-vars
branch
Merged
Boshen
added a commit
that referenced
this pull request
Aug 12, 2024
## [0.7.1] - 2024-08-12 ### Features - 3d40528 linter: Add fix emoji to rules table and doc pages (#4715) (DonIsaac) - d2734f3 linter: Start fixer for no-unused-vars (#4718) (DonIsaac) - 070ae53 linter: Add fixer for unicorn prefer-string-replace-all (#4801) (camc314) - b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac) - 5992b75 linter: Implement `eslint-plugin-promise/no-return-in-finally, prefer-await-to-then` rule (#4318) (Jelle van der Waa) - b259f47 linter: Add fixer for unicorn/no-length-as-slice-end (#4780) (heygsc) - abd83fa linter: Add fixer for jsx_ally/no_aria_hidden_on_focusable (#4772) (heygsc) - b20e335 linter: Add fixer for eslint/no-eq-null (#4758) (heygsc) - 2f6c3b9 linter: Add fixer for eslint/no-compare-neg-zero (#4748) (heygsc) - eaddc8f linter: Add fixer for eslint/func_names (#4714) (DonIsaac) - 80557a9 linter: Add fixer for eslint/for-direction (#4679) (heygsc) - c3c5766 linter/eslint-plugin-promise: Implement valid-params (#4598) (Jelle van der Waa) - c509a21 linter/eslint-plugin-vitest: Implement prefer-to-be-falsy (#4770) (dalaoshu) - 41f861f linter/eslint-plugin-vitest: Implement prefer-to-be-truthy (#4755) (dalaoshu) - cc922f4 vscode: Provide config's schema to oxlint config files (#4826) (Don Isaac) - f629514 website: Auto-generate rule docs pages (#4640) (DonIsaac) ### Bug Fixes - b22ed45 linter: Improve prefer_namespace_keyword rule (#4751) (Burlin) - db68a6c linter: Fixer for eslint/for-direction (#4727) (heygsc) - 6273994 linter: Block in eslint/no_cond_assign (#4721) (heygsc) - b9d6aa5 linter: Fix false positives in no-confusing-non-null-assertion (#4665) (Renée) - cbf08d2 linter: Skip no-multi-str on jsx attributes (#4666) (heygsc) - a6f9f96 linter: No unused errors should be warnings (Boshen) - 7345bc9 linter/func-names: Handle ts accessibility when reporting missing names (#4713) (DonIsaac) ### Performance - d191823 linter: Optmize allocations in jest fn parsing (#4787) (lucab) - e3abdfa linter: Reduce String allocations and clones (#4673) (DonIsaac) ### Documentation - 4b7dfd6 linter: Correct docs for no-unused-vars (#4716) (Don Isaac) ### Refactor - 096ac7b linter: Clean up jsx-a11y/anchor-is-valid (#4831) (DonIsaac) - 15a0fd4 linter: Use Option to reduce nested level in `eslint/getter-return` (#4814) (IWANABETHATGUY) - 63f274c linter: Simplify NoObjCalls resolution logic (#4765) (lucab) - 6708680 linter: Replace Windows-style line breaks with Unix-style in test fixture (#4768) (overlookmotel) - e285903 linter: Clean up eslint/func_names (#4710) (DonIsaac) ### Testing - 8f2a566 linter: Ensure rule docs have valid syntax (#4644) (DonIsaac) - 4dd29db linter: Add fixer test for unicorn/no-zero-fractions (#4783) (heygsc) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to add dangerous suggestions for
no-unused-vars. This PR focuses on fixing unused variable declarations.FixKindof dangerous suggestion."varsIgnorePattern"s with aFixKindof dangerous fix.