Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): remove excess space from start of doc comments #4782

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Aug 9, 2024

I noticed that in JSON schema the docs property contains e.g. " The name of the identifier being referenced." (with an excess space on the start). Trim that off.

Copy link

graphite-app bot commented Aug 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel marked this pull request as ready for review August 9, 2024 08:34
Copy link

codspeed-hq bot commented Aug 9, 2024

CodSpeed Performance Report

Merging #4782 will not alter performance

Comparing 08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments (c79ca40) with main (d4a3be8)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions branch from 627d746 to 5e6870c Compare August 9, 2024 09:57
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments branch from de08832 to d138825 Compare August 9, 2024 09:58
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions branch from 5e6870c to 9c9175a Compare August 9, 2024 10:08
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments branch 2 times, most recently from ba02f27 to 39177c9 Compare August 9, 2024 10:13
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 9, 2024
Copy link

graphite-app bot commented Aug 9, 2024

Merge activity

  • Aug 9, 6:17 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 9, 6:29 AM EDT: overlookmotel merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel changed the base branch from 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions to graphite-base/4782 August 9, 2024 10:17
@overlookmotel overlookmotel changed the base branch from graphite-base/4782 to main August 9, 2024 10:24
…#4782)

I noticed that in JSON schema the `docs` property contains e.g. `" The name of the identifier being referenced."` (with an excess space on the start). Trim that off.
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments branch from 39177c9 to c79ca40 Compare August 9, 2024 10:25
@graphite-app graphite-app bot merged commit c79ca40 into main Aug 9, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments branch August 9, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants