Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ast_codegen): line breaks between types in layout assertions #4781

Merged
merged 1 commit into from
Aug 9, 2024
Merged

refactor(ast_codegen): line breaks between types in layout assertions #4781

merged 1 commit into from
Aug 9, 2024

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Aug 9, 2024 •
edited
Loading

Small style nit. Add line breaks between types in generated layout assertions, to make the file easier to read.

This was referenced Aug 9, 2024
Merged
Merged
@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

This was referenced Aug 9, 2024
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Aug 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel marked this pull request as ready for review August 9, 2024 07:33
@github-actions github-actions bot added the A-ast Area - AST label Aug 9, 2024
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_ branch from a861c31 to 1e25ab5 Compare August 9, 2024 07:39
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions branch from 89d980d to f6cd942 Compare August 9, 2024 07:40
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_ branch from 1e25ab5 to 992f1cd Compare August 9, 2024 07:50
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions branch from f6cd942 to e65885d Compare August 9, 2024 07:50
@overlookmotel overlookmotel changed the base branch from 08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_ to 08-09-refactor_ast_codegen_re-order_code_in_fmt_module August 9, 2024 07:50
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch from e126245 to 58bc0de Compare August 9, 2024 07:57
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions branch from e65885d to a9fcafe Compare August 9, 2024 07:57
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4781 will not alter performance

Comparing 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions (d4a3be8) with main (966fcc9)

Summary

✅ 29 untouched benchmarks

rzvxa
rzvxa approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@rzvxa rzvxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, However, I've made some comments on the insert! macro PR.

@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch from 58bc0de to 94a6edc Compare August 9, 2024 08:23
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions branch from a9fcafe to 0f30bd3 Compare August 9, 2024 08:24
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch from 94a6edc to 601ba35 Compare August 9, 2024 08:33
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions branch from 0f30bd3 to 627d746 Compare August 9, 2024 08:33
This was referenced Aug 9, 2024
Merged
Merged
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 9, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 9, 2024 •
edited
Loading

Merge activity

  • Aug 9, 4:58 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 9, 4:58 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 9, 5:03 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #4779.
  • Aug 9, 5:04 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #4779.
  • Aug 9, 6:17 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 9, 6:17 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 9, 6:24 AM EDT: overlookmotel merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 9, 2024
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch from 601ba35 to 7bf49b8 Compare August 9, 2024 09:57
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions branch from 627d746 to 5e6870c Compare August 9, 2024 09:57
@overlookmotel overlookmotel mentioned this pull request Aug 9, 2024
Merged
@overlookmotel overlookmotel changed the base branch from 08-09-refactor_ast_codegen_re-order_code_in_fmt_module to graphite-base/4781 August 9, 2024 10:01
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions branch from 5e6870c to 9c9175a Compare August 9, 2024 10:08
@overlookmotel overlookmotel changed the base branch from graphite-base/4781 to main August 9, 2024 10:09
@overlookmotel overlookmotel mentioned this pull request Aug 9, 2024
Merged
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 9, 2024
@overlookmotel
refactor(ast_codegen): line breaks between types in layout assertions (…
d4a3be8 
…#4781)

Small style nit. Add line breaks between types in generated layout assertions, to make the file easier to read.
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions branch from 9c9175a to d4a3be8 Compare August 9, 2024 10:17
@graphite-app graphite-app bot merged commit d4a3be8 into main Aug 9, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions branch August 9, 2024 10:24
@oxc-bot oxc-bot mentioned this pull request Aug 10, 2024
Merged
Boshen added a commit that referenced this pull request Aug 10, 2024
@oxc-bot @Boshen
Release crates v0.24.1 (#4798)
857bc73 
## [0.24.1] - 2024-08-10

### Features

- b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac)
- c519295 minifier: Add `InjectGlobalVariables` plugin
(`@rollup/plugin-inject`) (#4759) (Boshen)

### Bug Fixes

- fff9da3 ast, ast_codegen: Use `generate_derive` instead of visitable
for generating span derives. (#4747) (rzvxa)
- f5eeebd ast_macros: Raise compile error on invalid `generate_derive`
input. (#4766) (rzvxa)
- 4d0b40a napi/transform: Fix wrong isolated declarations emit (Boshen)

### Refactor

- daa0b2e ast: `oxc_ast` crate re-export AST types from other crates
(#4773) (overlookmotel)
- d4a3be8 ast_codegen: Line breaks between types in layout assertions
(#4781) (overlookmotel)
- dbb5f4c ast_codegen: Remove unnecessary imports from generated files
(#4774) (overlookmotel)
- 7ea058d ast_codegen: Replace Windows-style line breaks with Unix-style
(#4769) (overlookmotel)
- 2dea0ca ast_codegen: Consistent import order (#4761) (overlookmotel)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzvxa rzvxa rzvxa approved these changes

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overlookmotel @rzvxa