feat(minifier): add InjectGlobalVariables plugin (@rollup/plugin-inject)
#4759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4759 will not alter performanceComparing Summary
|
|
In summary: Keeping scopes/symbols in sync is pretty annoying! |
|
@overlookmotel Thank you for the review. We should definitely revisit syncing semantic data in a follow up. |
Merge activity
|
Merged
Boshen
added a commit
that referenced
this pull request
Aug 10, 2024
## [0.24.1] - 2024-08-10 ### Features - b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac) - c519295 minifier: Add `InjectGlobalVariables` plugin (`@rollup/plugin-inject`) (#4759) (Boshen) ### Bug Fixes - fff9da3 ast, ast_codegen: Use `generate_derive` instead of visitable for generating span derives. (#4747) (rzvxa) - f5eeebd ast_macros: Raise compile error on invalid `generate_derive` input. (#4766) (rzvxa) - 4d0b40a napi/transform: Fix wrong isolated declarations emit (Boshen) ### Refactor - daa0b2e ast: `oxc_ast` crate re-export AST types from other crates (#4773) (overlookmotel) - d4a3be8 ast_codegen: Line breaks between types in layout assertions (#4781) (overlookmotel) - dbb5f4c ast_codegen: Remove unnecessary imports from generated files (#4774) (overlookmotel) - 7ea058d ast_codegen: Replace Windows-style line breaks with Unix-style (#4769) (overlookmotel) - 2dea0ca ast_codegen: Consistent import order (#4761) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Boshen
pushed a commit
that referenced
this pull request
Aug 10, 2024
…les` (#4802) Re-use `Atom`s in `InjectGlobalVariables` minifier plugin. Instead of allocating a new `Atom` on every replacement, create `Atom` lazily when making first replacement, and cache it. As discussed in: #4759 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.