Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): replace Windows-style line breaks with Unix-style #4769

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Aug 8, 2024

2 files in AST codegen had Windows-style CRLF line breaks. Change them to Unix-style LF. Does not alter contents of the files aside from the line breaks.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel marked this pull request as ready for review August 8, 2024 17:25
@overlookmotel
Copy link
Contributor Author

Trivial change so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 8, 2024
Copy link

graphite-app bot commented Aug 8, 2024

Merge activity

  • Aug 8, 1:27 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 8, 1:28 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 8, 1:32 PM EDT: overlookmotel merged this pull request with the Graphite merge queue.

…yle (#4769)

2 files in AST codegen had Windows-style CRLF line breaks. Change them to Unix-style LF. Does not alter contents of the files aside from the line breaks.
@overlookmotel overlookmotel force-pushed the 08-08-refactor_ast_codegen_replace_windows-style_line_breaks_with_unix-style branch from 95f4f0e to 7ea058d Compare August 8, 2024 17:29
@graphite-app graphite-app bot merged commit 7ea058d into main Aug 8, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 08-08-refactor_ast_codegen_replace_windows-style_line_breaks_with_unix-style branch August 8, 2024 17:32
Copy link

graphite-app bot commented Aug 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Aug 8, 2024

CodSpeed Performance Report

Merging #4769 will not alter performance

Comparing 08-08-refactor_ast_codegen_replace_windows-style_line_breaks_with_unix-style (7ea058d) with main (fff9da3)

Summary

✅ 29 untouched benchmarks

@oxc-bot oxc-bot mentioned this pull request Aug 10, 2024
Boshen added a commit that referenced this pull request Aug 10, 2024
## [0.24.1] - 2024-08-10

### Features

- b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac)
- c519295 minifier: Add `InjectGlobalVariables` plugin
(`@rollup/plugin-inject`) (#4759) (Boshen)

### Bug Fixes

- fff9da3 ast, ast_codegen: Use `generate_derive` instead of visitable
for generating span derives. (#4747) (rzvxa)
- f5eeebd ast_macros: Raise compile error on invalid `generate_derive`
input. (#4766) (rzvxa)
- 4d0b40a napi/transform: Fix wrong isolated declarations emit (Boshen)

### Refactor

- daa0b2e ast: `oxc_ast` crate re-export AST types from other crates
(#4773) (overlookmotel)
- d4a3be8 ast_codegen: Line breaks between types in layout assertions
(#4781) (overlookmotel)
- dbb5f4c ast_codegen: Remove unnecessary imports from generated files
(#4774) (overlookmotel)
- 7ea058d ast_codegen: Replace Windows-style line breaks with Unix-style
(#4769) (overlookmotel)
- 2dea0ca ast_codegen: Consistent import order (#4761) (overlookmotel)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant