Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data_structures): introduce AsciiChar #6537

Closed

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 13, 2024

Introduce AsciiChar. Copied from std::ascii::Char.

Copy link

graphite-app bot commented Oct 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

overlookmotel commented Oct 13, 2024

Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #6537 will not alter performance

Comparing 10-13-feat_data_structures_introduce_asciichar_ (50e6c68) with main (7e909a7)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 10-13-feat_data_structures_introduce_asciichar_ branch from 8c8c4d2 to 76691be Compare October 13, 2024 22:02
@overlookmotel overlookmotel changed the base branch from 10-13-docs_codegen_fix_example_for_codebuffer_print_ascii_bytes_ to 10-13-refactor_codegen_codegen_into_source_text_consume_codegen_ October 13, 2024 22:02
@overlookmotel overlookmotel force-pushed the 10-13-refactor_codegen_codegen_into_source_text_consume_codegen_ branch from 9dcf6c8 to f026c07 Compare October 13, 2024 22:09
@overlookmotel overlookmotel force-pushed the 10-13-feat_data_structures_introduce_asciichar_ branch from 76691be to dfcc8eb Compare October 13, 2024 22:09
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block merge. Needs discussion.

@Boshen Boshen force-pushed the 10-13-refactor_codegen_codegen_into_source_text_consume_codegen_ branch from f026c07 to c0e9d7e Compare October 14, 2024 01:10
@Boshen Boshen marked this pull request as draft October 14, 2024 01:25
Base automatically changed from 10-13-refactor_codegen_codegen_into_source_text_consume_codegen_ to main October 14, 2024 01:34
@Boshen Boshen force-pushed the 10-13-feat_data_structures_introduce_asciichar_ branch from dfcc8eb to 50e6c68 Compare October 14, 2024 01:34
@Boshen Boshen added the needs-discussion Requires a discussion from the core team label Oct 14, 2024
@overlookmotel overlookmotel removed the needs-discussion Requires a discussion from the core team label Oct 14, 2024
@overlookmotel
Copy link
Contributor Author

We discussed. Have closed #6538. AsciiChar is a useful abstraction which could be potentially used in lexer etc, but right now we have no use for it, so closing for now. We can can come back to it later if we find uses for it.

@Boshen Boshen deleted the 10-13-feat_data_structures_introduce_asciichar_ branch November 20, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants