-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(codegen): use AsciiChar
for statically unknowable characters
#6538
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on Graphite |
CodSpeed Performance ReportMerging #6538 will not alter performanceComparing Summary
|
Weird performance effects. I'll look into it. |
8c8c4d2
to
76691be
Compare
76691be
to
dfcc8eb
Compare
2ba1198
to
75fedc6
Compare
This is making the code way too complicated, can I reject? |
dfcc8eb
to
50e6c68
Compare
75fedc6
to
21226b2
Compare
Yes, I see your point. Too much complexity for not enough gain. |
Small optimization. Use
AsciiChar
(introduced in #6537) for pushing bytes to buffer where the byte values are not statically known.This also allows removing some unsafe code.