-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): support overrides
config field
#6974
base: don/10-26-refactor_linter_move_lintplugins_from_lintoptions_to_lintconfig_
Are you sure you want to change the base?
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
10fd2be
to
3f72622
Compare
let all_rules = RULES | ||
.iter() | ||
.filter(|rule| plugins.contains(LintPlugins::from(rule.plugin_name()))) | ||
.cloned() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to replace Vec<RuleWithSeverity>
with Vec<Cow<RuleWithSeverity>>
to avoid cloning individual rules unless their configs get changed by an override. Unfortunately, this requires a self-referential lifetime. Looking into it.
3f72622
to
aa1cfea
Compare
4c1f24b
to
f6a7fbb
Compare
aa1cfea
to
75b2411
Compare
Still needs tests. I'll add those tomorrow. |
CodSpeed Performance ReportMerging #6974 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test this locally.
I wonder how much of that is related to just reading the config file? What happens if you pass Nothing sticks out at me as being extremely slow here, I think I'd need to dive in and do some profiling first. |
f6a7fbb
to
0be2975
Compare
55818d9
to
3018e86
Compare
3018e86
to
37bb623
Compare
Part of #5653