feat(linter): support overrides config field

[DonIsaac]

Part of #5653

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[DonIsaac]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(linter): support overrides config field #6974 👈
• refactor(linter): move LintPlugins from LintOptions to LintConfig #6932
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

[DonIsaac]

I want to replace Vec<RuleWithSeverity> with Vec<Cow<RuleWithSeverity>> to avoid cloning individual rules unless their configs get changed by an override. Unfortunately, this requires a self-referential lifetime. Looking into it.

[DonIsaac]

Benchmarking on an internal codebase, I'm seeing a roughly 14% perf degredation with a single override that uses 4 glob patterns.

Config file:

{
  "categories": {
    "correctness": "error",
    "suspicious": "warn"
  },
  "rules": {
    "oxc/no-accumulating-spread": "warn"
  },
  "overrides": [
    {
      "files": ["*.spec.ts", "*.spec.tsx", "*.test.ts", "*.test.tsx"],
      "rules": {
        "oxc/no-accumulating-spread": "off",
        "@typescript-eslint/no-explicit-any": "off",
        "no-unused-vars": "off"
      }
    }
  ]
}

[DonIsaac]

Still needs tests. I'll add those tomorrow.

[codspeed-hq]

CodSpeed Performance Report

Merging #6974 will not alter performance

_{Comparing don/10-27-feat_linter_support_overrides_config_field (37bb623) with don/10-26-refactor_linter_move_lintplugins_from_lintoptions_to_lintconfig_ (0be2975)}

Summary

✅ 30 untouched benchmarks

[Boshen]

I'll test this locally.

[camchenry]

Benchmarking on an internal codebase, I'm seeing a roughly 14% perf degredation with a single override that uses 4 glob patterns.

I wonder how much of that is related to just reading the config file? What happens if you pass -c to both binaries, but one doesn't have an override.

Nothing sticks out at me as being extremely slow here, I think I'd need to dive in and do some profiling first.