Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): implement typescript/no-empty-object-type #6977

Merged
merged 7 commits into from
Nov 13, 2024
Merged

feat(linter): implement typescript/no-empty-object-type #6977

merged 7 commits into from
Nov 13, 2024

Conversation

Orenbek
Copy link
Contributor

@Orenbek Orenbek commented Oct 28, 2024 •
edited
Loading

@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Oct 28, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 28, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #6977 will not alter performance

Comparing Orenbek:oxlint-ts_rules (422a037) with main (2268a0e)

Summary

✅ 30 untouched benchmarks

@Orenbek Orenbek changed the title feat(oxlint): add typescript lint rule no_unsafe_function_type, no_empty_object_type feat(oxlint): add typescript lint rule no_empty_object_type Oct 29, 2024
@pumano
Copy link
Contributor

pumano commented Nov 7, 2024

@camchenry Could you check it too please? Useful rule

@camc314 camc314 requested a review from DonIsaac November 7, 2024 17:02
@camc314 camc314 requested a review from camchenry November 12, 2024 10:07
camc314
camc314 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@camc314 camc314 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

camchenry
camchenry approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your work on this. I think this looks good, I think the last thing we should do is add a separate diagnostic for empty interfaces. Then this looks like it should be ready.

crates/oxc_linter/src/snapshots/no_empty_object_type.snap Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/typescript/no_empty_object_type.rs Outdated Show resolved Hide resolved
camc314
camc314 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Orenbek thank you !

@camc314 camc314 changed the title feat(oxlint): add typescript lint rule no_empty_object_type feat(linter): implement typescript/no-empty-object-type Nov 13, 2024
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 13, 2024 •
edited
Loading

Merge activity

  • Nov 13, 4:30 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 13, 4:30 AM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024
@camc314 camc314 merged commit 9c91151 into oxc-project:main Nov 13, 2024
28 checks passed
Dunqing pushed a commit that referenced this pull request Nov 17, 2024
@Orenbek @Dunqing
feat(linter): implement typescript/no-empty-object-type (#6977)
4d9a52e
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
@Orenbek @Dunqing
feat(linter): implement typescript/no-empty-object-type (#6977)
9b0fdb3
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
@Orenbek @Dunqing
feat(linter): implement typescript/no-empty-object-type (#6977)
7a1e0f9
@oxc-bot oxc-bot mentioned this pull request Nov 20, 2024
Merged
Boshen added a commit that referenced this pull request Nov 20, 2024
@oxc-bot @Boshen
release(oxlint): v0.12.0 (#7366)
b6d5c0f 
## [0.12.0] - 2024-11-20

- 20d9080 linter: [**BREAKING**] Override plugins array when passed in
config file (#7303) (camchenry)

### Features

- 1d9f528 linter: Implement `unicorn/prefer-string-raw` lint rule
(#7335) (Ryan Walker)
- d445e0f linter: Implement `unicorn/consistent-existence-index-check`
(#7262) (Ryan Walker)
- 01ddf37 linter: Add `allowReject` option to
`no-useless-promise-resolve-reject` (#7274) (no-yan)
- 755a31b linter: Support bind function case for compatibility with
`promise/no-return-wrap` (#7232) (no-yan)
- 428770e linter: Add `import/no-namespace` rule (#7229) (Dmitry
Zakharov)
- 9c91151 linter: Implement typescript/no-empty-object-type (#6977)
(Orenbek)
- 2268a0e linter: Support `overrides` config field (#6974) (DonIsaac)
- 3dcac1a linter: React/exhaustive-deps (#7151) (camc314)
- d3a0119 oxlint: Add `cwd` property to `LintRunner` (#7352) (Alexander
S.)

### Bug Fixes

- ba0b2ff editor: Reload workspace configuration after change (#7302)
(Alexander S.)
- bc0e72c linter: Handle user variables correctly for import/no_commonjs
(#7316) (Dmitry Zakharov)
- bf839c1 linter: False positive in `jest/expect-expect` (#7341)
(dalaoshu)
- ff2a1d4 linter: Move `exhaustive-deps` to `react` (#7251) (camc314)
- df5c535 linter: Revert unmatched rule error (#7257) (Cameron A
McHenry)
- c4ed230 linter: Fix false positive in eslint/no-cond-assign (#7241)
(camc314)
- ef847da linter: False positive in `jsx-a11y/iframe-has-title` (#7253)
(dalaoshu)
- 62b6327 linter: React/exhaustive-deps update span for unknown deps
diagnostic (#7249) (camc314)

### Documentation

- 4c124a8 editor/vscode: Update VS Code readme with installation
instructions and available features (#7306) (Nicholas Rayburn)

### Refactor

- c6a4868 linter: Temporarily remove unknown rules checking (#7260)
(camchenry)

### Testing

- 5190b7f editor: Add test setup (#7361) (Alexander S.)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

@camchenry camchenry camchenry approved these changes

@DonIsaac DonIsaac Awaiting requested review from DonIsaac

Assignees
No one assigned
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Orenbek @pumano @camchenry @camc314 @DonIsaac