feat(linter): Add support for ignorePatterns property within config file #7092
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #7092 will not alter performanceComparing Summary
|
nrayburn-tech
force-pushed
the
support-ignores-config
branch
from
c4e2d96 to
a70b833
Compare
|
@Boshen Could you please a look at this PR? |
There was a problem hiding this comment.
I think this approach is okay for now, we'll likely need to adjust it when we support nested configuration. The main thing we should add in this PR is some test cases in apps/oxlint/fixtures. I would recommend adding a JSON config file that includes some common ignores patterns, and then add a test in apps/oxlint/src/lint.rs that the number of files is correct.
|
Do we want |
|
I’m hoping to get to the feedback here in the next few days. I’m also fine with just waiting until nested configs are supported and then creating a solution based on that if that would be preferred. |
I'm really waiting any of it. If team want to support v8 first, it's nice to have |
nrayburn-tech
force-pushed
the
support-ignores-config
branch
from
a70b833 to
1ac363c
Compare
nrayburn-tech
force-pushed
the
support-ignores-config
branch
from
1ac363c to
2717bf2
Compare
nrayburn-tech
changed the title
## [0.14.0] - 2024-12-01 ### Features - 32f860d linter: Add support for ignorePatterns property within config file (#7092) (Nicholas Rayburn) - 053bc08 linter: Implement typescript/no-unused-expressions (#7498) (camc314) - 60b28fc linter: Implement typescript/consistent-generic-constructors (#7497) (camc314) - bd0693b linter: Allow lint rules with the same name (#7496) (camc314) - 2ac9f96 linter: Typescript/no-inferrable-types (#7438) (camc314) - 8d89fdc linter: Add eslint/prefer-spread (#7112) (tbashiyy) ### Bug Fixes - 123b5b7 linter: False positive in `typescript/consistent-type-definitions` (#7560) (dalaoshu) - cc078d6 linter: Add missing error message prefix to `eslint/no-const-assign` (Boshen) - 17c0dd8 linter: Fix `jsx_no_script_url` doc failed to build (Boshen) ### Performance - 6cc7a48 linter: Use `OsString` for module cache hash (#7558) (Boshen) - 6655345 linter: Use `FxDashMap` for module cache (#7522) (overlookmotel) ### Documentation - a6b0100 linter: Fix config example headings (#7562) (Boshen) ### Refactor - 0f3f67a linter: Add capability of adding semantic data to module record (#7561) (Boshen) - 8392177 linter: Clean up the runtime after the module record change (#7557) (Boshen) - 823353a linter: Clean up APIs for `ModuleRecord` (#7556) (Boshen) - f847d0f linter: Call `str::ends_with` with array not slice (#7526) (overlookmotel) - 2077ff9 linter: Remove `once_cell` (#7510) (Boshen) - 169b8bf linter, syntax: Introduce type alias `FxDashMap` (#7520) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This could probably use some tests, but I'm not really sure what exactly should be tested.
Will leave a review with a few comments on things that might need a different approach.
Closes #7032.