Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement typescript/no-unused-expressions #7498

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Nov 27, 2024

No description provided.

Copy link

graphite-app bot commented Nov 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@camc314 camc314 marked this pull request as ready for review November 27, 2024 00:06
Copy link
Contributor Author

camc314 commented Nov 27, 2024

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Nov 27, 2024
Copy link

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #7498 will not alter performance

Comparing c/11-27-feat_linter_implement_typescript_no-unused-expressions (053bc08) with main (60b28fc)

Summary

✅ 30 untouched benchmarks

@camc314 camc314 force-pushed the c/11-26-feat_linter_implement_typescript_consistent-generic-constructors branch from 074102b to 0561aac Compare November 27, 2024 09:09
@camc314 camc314 force-pushed the c/11-27-feat_linter_implement_typescript_no-unused-expressions branch 2 times, most recently from 840d18a to a97a749 Compare November 27, 2024 09:13
@camc314 camc314 changed the base branch from c/11-26-feat_linter_implement_typescript_consistent-generic-constructors to graphite-base/7498 November 27, 2024 09:21
@camc314 camc314 force-pushed the c/11-27-feat_linter_implement_typescript_no-unused-expressions branch from a97a749 to c453241 Compare November 27, 2024 09:28
@camc314 camc314 changed the base branch from graphite-base/7498 to main November 27, 2024 09:29
@camc314 camc314 force-pushed the c/11-27-feat_linter_implement_typescript_no-unused-expressions branch from c453241 to 40664bd Compare November 27, 2024 09:29
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 27, 2024
Copy link
Contributor Author

camc314 commented Nov 27, 2024

Merge activity

  • Nov 27, 5:28 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 27, 5:28 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 27, 5:35 AM EST: A user merged this pull request with the Graphite merge queue.

@camc314 camc314 force-pushed the c/11-27-feat_linter_implement_typescript_no-unused-expressions branch from 40664bd to 053bc08 Compare November 27, 2024 10:28
@graphite-app graphite-app bot merged commit 053bc08 into main Nov 27, 2024
26 checks passed
@graphite-app graphite-app bot deleted the c/11-27-feat_linter_implement_typescript_no-unused-expressions branch November 27, 2024 10:35
@oxc-bot oxc-bot mentioned this pull request Dec 1, 2024
Boshen added a commit that referenced this pull request Dec 1, 2024
## [0.14.0] - 2024-12-01

### Features

- 32f860d linter: Add support for ignorePatterns property within config
file (#7092) (Nicholas Rayburn)
- 053bc08 linter: Implement typescript/no-unused-expressions (#7498)
(camc314)
- 60b28fc linter: Implement typescript/consistent-generic-constructors
(#7497) (camc314)
- bd0693b linter: Allow lint rules with the same name (#7496) (camc314)
- 2ac9f96 linter: Typescript/no-inferrable-types (#7438) (camc314)
- 8d89fdc linter: Add eslint/prefer-spread (#7112) (tbashiyy)

### Bug Fixes

- 123b5b7 linter: False positive in
`typescript/consistent-type-definitions` (#7560) (dalaoshu)
- cc078d6 linter: Add missing error message prefix to
`eslint/no-const-assign` (Boshen)
- 17c0dd8 linter: Fix `jsx_no_script_url` doc failed to build (Boshen)

### Performance

- 6cc7a48 linter: Use `OsString` for module cache hash (#7558) (Boshen)
- 6655345 linter: Use `FxDashMap` for module cache (#7522)
(overlookmotel)

### Documentation

- a6b0100 linter: Fix config example headings (#7562) (Boshen)

### Refactor

- 0f3f67a linter: Add capability of adding semantic data to module
record (#7561) (Boshen)
- 8392177 linter: Clean up the runtime after the module record change
(#7557) (Boshen)
- 823353a linter: Clean up APIs for `ModuleRecord` (#7556) (Boshen)
- f847d0f linter: Call `str::ends_with` with array not slice (#7526)
(overlookmotel)
- 2077ff9 linter: Remove `once_cell` (#7510) (Boshen)
- 169b8bf linter, syntax: Introduce type alias `FxDashMap` (#7520)
(overlookmotel)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants