Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semantic): report error for empty JSX attribute expression #8815

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 31, 2025

@Dunqing Dunqing requested a review from Boshen as a code owner January 31, 2025 15:34
Copy link
Member Author

Dunqing commented Jan 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #8815 will not alter performance

Comparing 01-31-feat_semantic_report_error_for_empty_jsx_attribute_expression (256ae78) with main (1a41181)

Summary

✅ 33 untouched benchmarks

@Dunqing Dunqing force-pushed the 01-31-feat_semantic_report_error_for_empty_jsx_attribute_expression branch from 02903a4 to 5d49e9a Compare January 31, 2025 15:53
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 1, 2025
Copy link

graphite-app bot commented Feb 1, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 01-31-feat_semantic_report_error_for_empty_jsx_attribute_expression branch from 5d49e9a to f6a735c Compare February 1, 2025 02:25
@graphite-app graphite-app bot force-pushed the 01-31-feat_semantic_report_error_for_empty_jsx_attribute_expression branch from f6a735c to 85abb93 Compare February 1, 2025 02:28
@graphite-app graphite-app bot force-pushed the 01-31-feat_semantic_report_error_for_empty_jsx_attribute_expression branch from 85abb93 to 256ae78 Compare February 1, 2025 02:30
@graphite-app graphite-app bot merged commit 256ae78 into main Feb 1, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-31-feat_semantic_report_error_for_empty_jsx_attribute_expression branch February 1, 2025 02:40
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant