Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ast): correct documentation for JSXExpression::EmptyExpression #8816

Merged
merged 1 commit into from
Feb 1, 2025
Merged

docs(ast): correct documentation for JSXExpression::EmptyExpression #8816

merged 1 commit into from
Feb 1, 2025
+2 −2

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 31, 2025

No description provided.

@Dunqing Dunqing mentioned this pull request Jan 31, 2025
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Jan 31, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Jan 31, 2025
Draft
@Dunqing Dunqing changed the title docs(ast): correct documentation for JSXExpression::EmptyExpression docs(ast): correct documentation for JSXExpression::EmptyExpression Jan 31, 2025
@github-actions github-actions bot added A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation labels Jan 31, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 31, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8816 will not alter performance

Comparing 01-31-docs_ast_correct_documentation_for_jsxexpression_emptyexpression (b00b8c8) with main (1a41181)

Summary

✅ 33 untouched benchmarks

@Dunqing Dunqing force-pushed the 01-31-feat_semantic_report_error_for_empty_jsx_attribute_expression branch from 02903a4 to 5d49e9a Compare January 31, 2025 15:53
@Dunqing Dunqing requested a review from Boshen as a code owner January 31, 2025 15:53
@Dunqing Dunqing force-pushed the 01-31-docs_ast_correct_documentation_for_jsxexpression_emptyexpression branch from 90a2999 to 5aea3cf Compare January 31, 2025 15:53
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 1, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Feb 1, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Jan 31, 9:24 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 31, 9:24 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 31, 9:43 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 01-31-feat_semantic_report_error_for_empty_jsx_attribute_expression branch from 5d49e9a to f6a735c Compare February 1, 2025 02:25
graphite-app bot pushed a commit that referenced this pull request Feb 1, 2025
@Dunqing
docs(ast): correct documentation for JSXExpression::EmptyExpression (…
da6d778 
…#8816)
@graphite-app graphite-app bot force-pushed the 01-31-docs_ast_correct_documentation_for_jsxexpression_emptyexpression branch from 5aea3cf to da6d778 Compare February 1, 2025 02:25
@graphite-app graphite-app bot force-pushed the 01-31-feat_semantic_report_error_for_empty_jsx_attribute_expression branch from f6a735c to 85abb93 Compare February 1, 2025 02:28
graphite-app bot pushed a commit that referenced this pull request Feb 1, 2025
@Dunqing
docs(ast): correct documentation for JSXExpression::EmptyExpression (…
31492f3 
…#8816)
@graphite-app graphite-app bot force-pushed the 01-31-docs_ast_correct_documentation_for_jsxexpression_emptyexpression branch from da6d778 to 31492f3 Compare February 1, 2025 02:29
@graphite-app graphite-app bot force-pushed the 01-31-feat_semantic_report_error_for_empty_jsx_attribute_expression branch from 85abb93 to 256ae78 Compare February 1, 2025 02:30
@graphite-app graphite-app bot force-pushed the 01-31-docs_ast_correct_documentation_for_jsxexpression_emptyexpression branch from 31492f3 to b00b8c8 Compare February 1, 2025 02:31
Base automatically changed from 01-31-feat_semantic_report_error_for_empty_jsx_attribute_expression to main February 1, 2025 02:40
@graphite-app graphite-app bot merged commit b00b8c8 into main Feb 1, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 01-31-docs_ast_correct_documentation_for_jsxexpression_emptyexpression branch February 1, 2025 02:43
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dunqing @Boshen