-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add top-level retry loop. #21
Conversation
7c0dede
to
36f1067
Compare
I'm a bit confused as to why drone CI is failing; black seems to be complaining about a missing comma after the
|
Hmm, I guess drone was just confused about which revision it was really looking at or something; it now seems to be placated. |
Yeah, this is a common issue with drone. Sometimes it seems to pull back stale data. Typically re-running the build will resolve it. |
Ah, okay -- is there an easy way to trigger another run? I could have sworn I saw a "retry" button in its UI at some point, but now I can't find it... |
We've been hitting some intermittent crashes of the following form recently: Traceback (most recent call last): File "/usr/local/bin/packet-networking", line 11, in <module> sys.exit(cli()) File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 722, in __call__ return self.main(*args, **kwargs) File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 697, in main rv = self.invoke(ctx) File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 895, in invoke return ctx.invoke(self.callback, **ctx.params) File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 535, in invoke return callback(*args, **kwargs) File "/usr/local/lib/python3.5/dist-packages/packetnetworking/cli.py", line 107, in cli tasks = builder.run(rootfs) File "/usr/local/lib/python3.5/dist-packages/packetnetworking/builder.py", line 67, in run return builder.run(rootfs_path) File "/usr/local/lib/python3.5/dist-packages/packetnetworking/distros/distro_builder.py", line 163, in run rendered_tasks = self.render() File "/usr/local/lib/python3.5/dist-packages/packetnetworking/distros/distro_builder.py", line 156, in render rendered_tasks[path] = template.render(self.context()) File "/usr/local/lib/python3.5/dist-packages/jinja2/environment.py", line 1008, in render return self.environment.handle_exception(exc_info, True) File "/usr/local/lib/python3.5/dist-packages/jinja2/environment.py", line 780, in handle_exception reraise(exc_type, exc_value, tb) File "/usr/local/lib/python3.5/dist-packages/jinja2/_compat.py", line 37, in reraise raise value.with_traceback(tb) File "<template>", line 13, in top-level template code jinja2.exceptions.UndefinedError: 'None' has no attribute 'address' Current speculation is that this is due to some sort of hegel race; until the root cause is determined & fixed we're hoping this will keep things running.
Yeah, committed & pushed a little prematurely there...now updated with the fix. |
Yeah, due to the way this is configured using a drone matrix, you'd have to go into each of the python version and restart it by clicking the hamburger icon at the right and click restart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
We've been hitting some intermittent crashes of the following
form recently:
Current speculation is that this is due to some sort of hegel race;
until the root cause is determined & fixed we're hoping this will keep
things running.
[As requested by @truongmd, CC also @dlaube, @dustinmiller1337. Note that I have basically no idea what I'm doing in this codebase, so please review accordingly; apologies if I've done something grossly wrong.]